Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to swap Fan icon #123

Closed
ricardotpo opened this issue Nov 28, 2022 · 7 comments · Fixed by #131
Closed

Unable to swap Fan icon #123

ricardotpo opened this issue Nov 28, 2022 · 7 comments · Fixed by #131
Labels
bug Something isn't working
Milestone

Comments

@ricardotpo
Copy link

Hi all,
I think I found a bug.

I've got a Tuya ceiling fan installed and working, however the icon on homekit is of a table top fan.
When I go to the device settings and try to tap on the fan icon to swap it, nothing happens.

Other than this, I have nothing but compliments !
This plugin is incredibly better than the official one.
Excellent work guys !

@ricardotpo ricardotpo added the bug Something isn't working label Nov 28, 2022
@0x5e
Copy link
Owner

0x5e commented Nov 28, 2022

Hi @ricardotpo,
Icon customize feature is provided by homekit app, most accessories don't support icon changing, only few supported (Switch, Light).
See #93 .

@r2shyyou
Copy link

r2shyyou commented Nov 28, 2022

image

there is a fan device/accessory type that allows switching icons, as shown in attached

i came across this in the homebridge-irobot plugin, which uses a type of fan accessory to surface the vacuum

@0x5e
Copy link
Owner

0x5e commented Nov 28, 2022

image

there is a fan device/accessory type that allows switching icons, as shown in attached

i came across this in the homebridge-irobot plugin, which uses a type of fan accessory to surface the vacuum

Thanks for the information, I will review it's code to see how it do.

@ricardotpo
Copy link
Author

@0x5e Thank you !
I was not expecting such a fast response !

@0x5e
Copy link
Owner

0x5e commented Nov 29, 2022

@ricardotpo @r2shyyou There's two services: Fan and Fanv2, I'm using Fanv2 and homebridge-irobot is using Fan.
Fan has more customizable icons, while Fanv2 has more characteristics (mode: auto/manual, child lock, swing).

Seems the custom icon requirements is strong, before mode/child lock/swing implemented, I will use Fan instead.

@0x5e
Copy link
Owner

0x5e commented Nov 29, 2022

So for the fs and fskg category, I need to check their schema and if one of the mode, lock, swing exists, I will treate it as Fanv2, else Fan. I think that's a final solution. Besides there's some cache cleanning work to be done.

@0x5e 0x5e added this to the 1.7.0 milestone Dec 3, 2022
@0x5e
Copy link
Owner

0x5e commented Dec 3, 2022

Please try 1.7.0-beta.1, should work now :)

@0x5e 0x5e closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants