Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deck Validity Status when Constructing Deck #111

Open
eviterin opened this issue Jan 24, 2024 · 1 comment
Open

Add Deck Validity Status when Constructing Deck #111

eviterin opened this issue Jan 24, 2024 · 1 comment

Comments

@eviterin
Copy link
Collaborator

eviterin commented Jan 24, 2024

There are currently three constraints for a deck to be considered valid:

  1. Number of cards >= 10
  2. Number of cards <= 62
  3. Copies of same card <= 3

The deck not fulfilling these constraints should not hinder them from saving the deck.
But they will instead be enforced before every game.

It would make sense to create some indicators for the player while they are modifying their deck on the validity status.
Also, it would be good if the player could see the validity status of all their decks from the collection view.

Finally, a player may not own more than 256 decks.
It would be good if the player could see how many decks out of these 256 they have.
We'll need to add a warning when that limit is reached + hide the "new deck" button when that occurs.

@norswap
Copy link
Member

norswap commented Jan 25, 2024

To clarify, the check made before the game is already implemented here and run currently! It's implemented here

So that only leaves the check in the frontend, we can do that by calling the implementation and checking if it throws an error (and down the line use the specific error to print a message that points out the specific problem).

I'm not sure what constructor you're referring to in the title?

Regarding the deck limitation, I wouldn't worry about it too much, 256 is plenty, we'll just need to add a warning when that limit is reached + hide the "new deck" button when that occurs.

@eviterin eviterin changed the title Add Deck Validity Status in Constructor Add Deck Validity Status when Constructing Deck Jan 28, 2024
@eviterin eviterin self-assigned this Feb 7, 2024
@norswap norswap added ODHack and removed ODHack labels Feb 14, 2024
@eviterin eviterin mentioned this issue Mar 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants