Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load spread in the center of the orderbook panel #479

Open
burnsben opened this issue May 28, 2019 · 7 comments
Open

Load spread in the center of the orderbook panel #479

burnsben opened this issue May 28, 2019 · 7 comments
Assignees
Labels

Comments

@burnsben
Copy link

The spread is currently not centered in the panel on page load.

Screen Shot 2019-05-28 at 3 39 10 PM

Also the text needs to be centered in this space
Screen Shot 2019-05-28 at 3 41 56 PM

View the mock for guidance on how this middle section should look:
Screen Shot 2019-05-28 at 3 41 16 PM

@burnsben
Copy link
Author

Could use about 3 more pixels of padding above the text

@gabitoesmiapodo
Copy link
Contributor

@burnsben

About "The spread is currently not centered in the panel on page load.": It will only get centered if there are enough elements above and below the Spread. Otherwise it's not possible for the list to scroll to get the Spread vertically centered.

In other words: if you are not able to scroll it manually, it can't be done automatically.

Not sure if that is the case with your example, could you confirm if it's possible for you to scroll the spread where you want it, but it refuses to do it by itself on page loading?

@gabitoesmiapodo gabitoesmiapodo self-assigned this May 29, 2019
@gabitoesmiapodo gabitoesmiapodo added the question Further information is requested label May 29, 2019
@burnsben
Copy link
Author

My bad, it seems to be loading fine now, can't repro the issue I had the other day. Hoping we can keep a high priority tag on getting the "spread" text centered in that space.

@mariano-aguero mariano-aguero added the 0x feedback 0x team feedback label May 30, 2019
@gabitoesmiapodo gabitoesmiapodo added in progress and removed question Further information is requested in progress labels May 30, 2019
@gabitoesmiapodo
Copy link
Contributor

@burnsben

My bad, it seems to be loading fine now, can't repro the issue I had the other day. Hoping we can keep a high priority tag on getting the "spread" text centered in that space.

centered

If I understand correctly, that's what you'd like to see.

It would be possible to do that by wrapping the content of each cell in that column (for example in a span element), having that span centered horizontally within the cell, and at the same time aligning the span's text to the right.

Something like this pseudo code:

<Column>
  <Cell><span style={ width: widerSpan; text-align: right; }>Some content</span></Cell>
  <Cell><span style={ width: widerSpan; text-align: right; }>Some content</span></Cell>
  <Cell><span style={ width: widerSpan; text-align: right; }>Some content</span></Cell>
  <Cell><span style={ width: widerSpan; text-align: right; }>Some content</span></Cell>
</Column>

The problem is: for this to work, all these spans should be the same width as the wider span in that column, and I can't think of an easy and non messy way to do this with our current implementation.

@burnsben
Copy link
Author

burnsben commented Jun 1, 2019

Sorry if I was unclear, the issue here is that the "spread" text is not centered vertically. It has a few less pixels above than below.
58517117-25595b00-815f-11e9-8d13-3b0101452d8a

@burnsben
Copy link
Author

burnsben commented Jun 1, 2019

Screen Shot 2019-05-31 at 5 34 26 PM

here's a wider crop for context.

@chriskalani
Copy link

I want to make sure this one doesn't get lost. We're still seeing the 2 UI issues Ben mentioned in the comments here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants