Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors from ecSignOrderAsync not being handled #579

Open
albrow opened this issue Dec 6, 2019 · 0 comments
Open

Errors from ecSignOrderAsync not being handled #579

albrow opened this issue Dec 6, 2019 · 0 comments

Comments

@albrow
Copy link
Contributor

albrow commented Dec 6, 2019

I had a bug in my code that caused signatureUtils.ecSignOrderAsync to reject/throw here. It was difficult to track down what was going on because AFAICT the error is just being swallowed up without being logged.

There might be an easier way to reproduce this, but here's more or less what I did:

  1. Modify getOrderWithTakerAndFeeConfigFromRelayer to include an invalid field. I had accidentally set makerFeeAssetData to 0x0 instead of 0x.
  2. Open launch kit front end in your browser and try to create an order. The MetaMask pop up never shows up and it just says it failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant