You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the inlining logic to be based on file size. For example if a CSS file is 100K, it should not be inlined. If it is 4K, it should be. I suggest 40K as a reasonable cutoff.
This should also be configurable.
The text was updated successfully, but these errors were encountered:
Would not it be better to have a feature that enables us to define which css files should be inline? That is, make split of my-app.css ensuring that we can choose the critical css
@villander there are indeed tools that can determine critical css and we could use them + fastboot or headless chrome to figure out what is best for above the fold. Everything is incremental though. My goal with the this addon was for it to be simple enough that we could consider adding it to the default Ember addon list.
The naive iterative approach I've stated with should not be read as a rejection of the more complex critical css approach 👍
Change the inlining logic to be based on file size. For example if a CSS file is 100K, it should not be inlined. If it is 4K, it should be. I suggest 40K as a reasonable cutoff.
This should also be configurable.
The text was updated successfully, but these errors were encountered: