Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline based on size #6

Open
mixonic opened this issue Sep 13, 2017 · 2 comments
Open

Inline based on size #6

mixonic opened this issue Sep 13, 2017 · 2 comments

Comments

@mixonic
Copy link
Member

mixonic commented Sep 13, 2017

Change the inlining logic to be based on file size. For example if a CSS file is 100K, it should not be inlined. If it is 4K, it should be. I suggest 40K as a reasonable cutoff.

This should also be configurable.

@villander
Copy link

Would not it be better to have a feature that enables us to define which css files should be inline? That is, make split of my-app.css ensuring that we can choose the critical css

@mixonic
Copy link
Member Author

mixonic commented Mar 19, 2018

@villander there are indeed tools that can determine critical css and we could use them + fastboot or headless chrome to figure out what is best for above the fold. Everything is incremental though. My goal with the this addon was for it to be simple enough that we could consider adding it to the default Ember addon list.

The naive iterative approach I've stated with should not be read as a rejection of the more complex critical css approach 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants