Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLow? #1

Open
Dreded opened this issue Jan 12, 2020 · 2 comments
Open

SLow? #1

Dreded opened this issue Jan 12, 2020 · 2 comments
Assignees

Comments

@Dreded
Copy link

Dreded commented Jan 12, 2020

Really appreciate the work you have done and I realize this is 3yrs old but...
This seams overly slow... is it me,python or the way this library works?
takes 1-2seconds per game to unlazify so to do an entire steam library(mine is 475 games) it would take 15minutes. when I use an online based solution they take under 1 second for 50 entries(pagified)

@4Kaylum
Copy link
Owner

4Kaylum commented Jan 12, 2020

I genuinely had no idea that people still used this library, honestly.

Looking back at it, it seems I've programmed it to run a GET request for every app you pass to it. This looks like it could easily be solved by bulking the data, ie sending multiple app IDs at once (though I'd need to look into that to be sure).

I'm more than happy for you to PR a change if you wanted to. If not then I'll look into writing this library a lot better, if I remember. I like to think I've learned a lot in three years.

@4Kaylum 4Kaylum self-assigned this Jan 12, 2020
@Dreded
Copy link
Author

Dreded commented Jan 13, 2020

thanks for the response,
well it still works and is the only library that seams to be able to get the store page info... I am trying to make someone to catalogue all the games from different services that I have. I am quite the newb for this sort of thing, so me making changes is probably not a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants