Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Move sub-tabs to sidebar #1295

Closed
lukasschor opened this issue Aug 27, 2020 · 5 comments · Fixed by #2521
Closed

Move sub-tabs to sidebar #1295

lukasschor opened this issue Aug 27, 2020 · 5 comments · Fixed by #2521
Assignees
Labels
effort-mid Medium-effort issues Feature 👑 New functionality
Milestone

Comments

@lukasschor
Copy link
Member

lukasschor commented Aug 27, 2020

What is this feature about? (1 sentence)

This will implement the new design for the sub-tabs in settings and assets view by moving the selection to the sidebar.

Why is it needed? What is the value? For whom do we build it?

  • This provides more space for the settings screens.
  • It makes the collectibles section more discoverable

High-level overview of the feature

  • This ticket is about the collapsible section for assets and settings.
    • i.e. not Safe apps
  • Navigation specs according to this comment below
    • Opening the arrow toggles expanded and collapsed state. Both when being in the settings and when being somewhere else.
    • Clicking "Settings" automatically expands it and opens the "Safe details", i.e. the first item in the dropdown.
      Can the settings section be collapsed when I am in the settings?
    • Accessing a non-Settings screen collapses the settings section.

@lukasschor lukasschor added Feature 👑 New functionality Major Needs to be fixed for immediate next public release. labels Aug 27, 2020
@tschubotz tschubotz removed the Major Needs to be fixed for immediate next public release. label Oct 6, 2020
@tschubotz
Copy link
Member

@posthnikova I have some questions about the navigation here:

  • When the settings section is collapsed, which screen should open when tapping it? Owners?
  • Can the settings section be collapsed when I am in the settings?
  • Assuming I am on "Policies", I go to the transaction list, does this collapse the settings section?
    • If yes, what screen opens when tapping "settings" again in the sidebar?

@posthnikova
Copy link

When the settings section is collapsed, which screen should open when tapping it? Owners?

Safe details. You end up on the first screen in the dropdown.

Can the settings section be collapsed when I am in the settings?

Yes. You can collapse or expand any dropdown when you click on the arrow.

Assuming I am on "Policies", I go to the transaction list, does this collapse the settings section?

Yes. The dropdown collapses when you go to another section.

If yes, what screen opens when tapping "settings" again in the sidebar?

Safe details, again. But you can expand the 'Settings' dropdown and go directly to policies.

@tschubotz
Copy link
Member

Thanks, added this to the ticket description.

@lukasschor lukasschor changed the title Move settings selection to sidebar Move sub-tabs to sidebar Apr 17, 2021
@katspaugh
Copy link
Member

@alongoni says the component already supports sub-menus. It's in the safe-react storybook.

@katspaugh
Copy link
Member

Add links to the setting tabs so that they have their own URLs.

@katspaugh katspaugh added the effort-mid Medium-effort issues label May 28, 2021
@katspaugh katspaugh added this to the 3.10.0 milestone Jul 1, 2021
@dasanra dasanra self-assigned this Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort-mid Medium-effort issues Feature 👑 New functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants