Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Deep link - Tx shown in history and queue tabs at the same time #3070

Closed
francovenica opened this issue Nov 28, 2021 · 2 comments · Fixed by #3156
Closed

Deep link - Tx shown in history and queue tabs at the same time #3070

francovenica opened this issue Nov 28, 2021 · 2 comments · Fixed by #3156
Assignees
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Comments

@francovenica
Copy link
Contributor

francovenica commented Nov 28, 2021

Description

This is for tx that are created and executed right away for having a 1 owner policy. The tx is executed fine, but is shown both in history and Queue tab, and it can even be executed again (the tx will end up failing since it was already executed)

Environment

Steps to reproduce

Create a safe with 1 owner
Create a tx (any type of tx will sufice, adding an owner for example) and execute it right away
Remain in the "Deep link" view of the tx until the message pops up saying the tx was executed successfully
Go to the queue Tab

Expected result

The tx should only be in the History tab

Obtained result

The tx is present in both the Queue and history tab at the same time.

Screenshots

11-28-2021_x(3559)

@francovenica francovenica added Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. labels Nov 28, 2021
@iamacook
Copy link
Member

I think we'll have to double-check the gatewayTransactions reducer that we remove queued transactions after they become historical.

@francovenica
Copy link
Contributor Author

Since the issue of the tx showing in the queue and history in the same tab is not happening anymore we will close this ticket as fixed. Any other issues related to deep link will be treated in new issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants