Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix apps broken by chain name change #3339

Closed
dasanra opened this issue Jan 20, 2022 · 2 comments
Closed

Fix apps broken by chain name change #3339

dasanra opened this issue Jan 20, 2022 · 2 comments
Assignees
Labels
Bug 🐛 Something isn't working Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.

Comments

@dasanra
Copy link
Collaborator

dasanra commented Jan 20, 2022

Description

Many apps broke because we now are returning the chainName directly from web, and so apps don't understand Ethereum as Mainnet or xDai as GnosisChain

We should try to fix this meanwhile overwritting this names until we can get all apps affected updated to a recent version of the SDK

Steps to reproduce

Try to open xDai Bridge either on Mainnet or xDai. App is not able to connect to the Safe.

Expected result

xDai bridge app should automatically connect to the Safe and allow to be used

Obtained result

Safe can't be connected and error message in console returning unknown network

@dasanra dasanra self-assigned this Jan 20, 2022
@dasanra dasanra added Bug 🐛 Something isn't working Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. labels Jan 20, 2022
@JagoFigueroa
Copy link

All good, thank you guys! Also approved all of the [Mainnet App] not working tickets ;)

@JagoFigueroa
Copy link

Taking the liberty to close this ticket as it has already been merged to prod ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.
Projects
None yet
Development

No branches or pull requests

2 participants