Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

WalletConnect approval transactions not proposing #3448

Closed
iamacook opened this issue Feb 7, 2022 · 0 comments · Fixed by #3455
Closed

WalletConnect approval transactions not proposing #3448

iamacook opened this issue Feb 7, 2022 · 0 comments · Fixed by #3455
Assignees
@katspaugh
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Comments

@iamacook
Copy link
Member

iamacook commented Feb 7, 2022

Description

Approval transactions via WalletConnect are not proposing to and therefore not saving in the queue.

Only once transactions are submitted, does the Safe propose the transaction. When using WalletConnect, there is most likely no transaction hash and therefore no proposal occuring.

Steps to reproduce

With Safe A owning Safe B: create a transaction and approve the hash in Safe A, observing that the transaction does not appear in the queue of Safe B.

Expected result

Transaction appears in the queue of Safe B.

Obtained result

Transaction does not appear in the queue.

Links
@iamacook iamacook added the Bug 🐛 Something isn't working label Feb 7, 2022
@katspaugh katspaugh mentioned this issue Feb 7, 2022
Closed
@katspaugh katspaugh added the Major Needs to be fixed for immediate next public release. label Feb 8, 2022
@iamacook iamacook self-assigned this Feb 8, 2022
@katspaugh katspaugh mentioned this issue Feb 8, 2022
Merged
@katspaugh katspaugh assigned katspaugh and unassigned iamacook Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@katspaugh katspaugh

Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: propose when creating or signing 5afe/safe-react
2 participants
@katspaugh @iamacook