Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[Epic] Roles: transaction drafters #3955

Open
2 tasks
DiogoSoaress opened this issue Jun 9, 2022 · 5 comments
Open
2 tasks

[Epic] Roles: transaction drafters #3955

DiogoSoaress opened this issue Jun 9, 2022 · 5 comments
Labels

Comments

@DiogoSoaress
Copy link
Member

DiogoSoaress commented Jun 9, 2022

Overview

The Safe UI is missing a way to manage transaction drafters (aka delegates)

Requirements

  • Implement a Settings page for transaction drafters management
  • Update the Client GW SDK to expose the CRUD /delegates endpoints

Timeline

  • Picking up the current PoC it should take around 3 working days to connect with the SDK endpoints (instead of calling Transaction Service directly).
    Design rework will add to this estimation which should not blow 1 week of work

  • Client GW SDK has an open PR that should take 1 working day to finalize.

Designs

Requires @liliiaorlenko
Screenshot 2022-06-07 at 11 04 15
Screenshot 2022-06-07 at 11 05 41
Screenshot 2022-06-07 at 11 06 20

Links

Notion doc
Original Problem Statement

Transaction Service API
Gnosis-Safe Delegation DAPP (external)

@iamacook
Copy link
Member

iamacook commented Jun 9, 2022

Does the timeline take into account the adjustments required on backend and allowance of transaction proposal by delegates?

@DiogoSoaress
Copy link
Member Author

Does the timeline take into account the adjustments required on backend and allowance of transaction proposal by delegates?

Only frontend work as we agreed in the meeting earlier. IIRC

@iamacook
Copy link
Member

iamacook commented Jun 9, 2022

Only frontend work as we agreed in the meeting earlier. IIRC

We need to adjust the proposal logic though if we want to allow delegates to draft transactions or is this epic purely for the CRUD system?

@DiogoSoaress
Copy link
Member Author

The way I wrote it was for delegate role management purely. However you have a valid question. cc @johannesmoormann

@DiogoSoaress
Copy link
Member Author

I reached out to backend as the DELETE HTTP method, used to delete transaction delegates, is not allowed by CORS policy in the Client GW.

@johannesmoormann this is a dependency we have on the backend team (as @iamacook had identified before)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants