Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit confirmation dialog when back pressed in water view #141

Closed
9YbQiuEohUu1 opened this issue Sep 25, 2019 · 3 comments
Closed

Add exit confirmation dialog when back pressed in water view #141

9YbQiuEohUu1 opened this issue Sep 25, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@9YbQiuEohUu1
Copy link

When you press "Feed Again," the action is created at once, so if you then try to exit without pressing the green button in the lower right corner, the action will still be there.

@7LPdWcaW
Copy link
Owner

This is actually intended behaviour, I see it more as a "you've applied the feeding again and now you are editing it" rather than a "copy from previous feeding" which is a separate option within the menu.

I chose this for instances where you may have pre-mixed nutrients that you use to water over multiple days (where the details do not change. basically a quick action for duplicate & set to current date)

@9YbQiuEohUu1
Copy link
Author

This is actually a good idea (I actually use it more often than creating a new watering to avoid typing the parameters each time). However, the fact that it saves the watering regardless of whether you confirm or cancel the action is counterintuitive and goes against the general behavior of android apps. E.g. I tap it by mistake, i press back and I expect it not to be there. Instead, I have to then go to history and delete it (worse yet, I may not go there at all and later find it and not even know whether it is a real watering or an erroneous duplicate). Again, not a big deal but rather a minor nuisance. Maybe a better idea would be "you've applied the feeding again and now you are editing it but if you press Back instead of Confirm you delete it."
Just to clarify - I realy like how functional the app is and how well the options are organized. Thank you for all the great work.

@7LPdWcaW
Copy link
Owner

👍 I think thats probably a reasonable addition

@7LPdWcaW 7LPdWcaW changed the title "Feed Again" saves the action before it is confirmed Add exit confirmation dialog when back pressed in water view Sep 26, 2019
@7LPdWcaW 7LPdWcaW self-assigned this Sep 26, 2019
@7LPdWcaW 7LPdWcaW added this to the v2.6 milestone Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants