From 7e227d55dcbcee168c19ee55ec20fd0d6f57604c Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Fri, 24 May 2024 09:28:26 +0300 Subject: [PATCH] refactor: simplify with strconv.FormatBool --- graphql/bool.go | 7 +++---- graphql/string.go | 6 +----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/graphql/bool.go b/graphql/bool.go index ff6792ae71..56d734f7c2 100644 --- a/graphql/bool.go +++ b/graphql/bool.go @@ -3,14 +3,13 @@ package graphql import ( "fmt" "io" + "strconv" "strings" ) func MarshalBoolean(b bool) Marshaler { - if b { - return WriterFunc(func(w io.Writer) { w.Write(trueLit) }) - } - return WriterFunc(func(w io.Writer) { w.Write(falseLit) }) + str := strconv.FormatBool(b) + return WriterFunc(func(w io.Writer) { w.Write([]byte(str)) }) } func UnmarshalBoolean(v any) (bool, error) { diff --git a/graphql/string.go b/graphql/string.go index 3a58c117dd..61da5810f2 100644 --- a/graphql/string.go +++ b/graphql/string.go @@ -60,11 +60,7 @@ func UnmarshalString(v any) (string, error) { case json.Number: return string(v), nil case bool: - if v { - return "true", nil - } else { - return "false", nil - } + return strconv.FormatBool(v), nil case nil: return "null", nil default: