Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Remove NSLogs #97

Closed
merkury opened this issue Jun 17, 2015 · 4 comments
Closed

Remove NSLogs #97

merkury opened this issue Jun 17, 2015 · 4 comments

Comments

@merkury
Copy link

merkury commented Jun 17, 2015

Is it please possible to remove the NSLogs in the AFOAuth2Mangaer.m ?
It logs the identifier of the keychain entry. This can be used by other apps to get the credentials.

Regards David

@merkury
Copy link
Author

merkury commented Jun 23, 2015

For me this is a serious security issue and should be fixed soon. Just removing the NSLog statements from AFOAuth2Manager.m will fix it.

@svenmuennich
Copy link
Contributor

👍

I totally agree. It is also bit annoying during development, e.g. when checking if a credential is already stored in a shared keychain.

@svenmuennich
Copy link
Contributor

I just created PR #99 that removes all NSLog calls.

@kcharwood
Copy link
Contributor

Merged

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants