Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download stats on Hugging Face, improve discoverability #83

Open
NielsRogge opened this issue Jul 15, 2024 · 2 comments
Open

Fix download stats on Hugging Face, improve discoverability #83

NielsRogge opened this issue Jul 15, 2024 · 2 comments

Comments

@NielsRogge
Copy link

Hi VideoCrafter team,

Congrats on this work! It's great to see the checkpoints being released on HF 🤗

Download stats

I see that currently download stats aren't working for your model. This is due to the model repositories not containing a config.json or config.yaml file. See here for more info: https://huggingface.co/docs/hub/models-download-stats.

There are a few options here to make them work:

  1. either we can open a PR on the huggingface.js repository to view "VideoCrafter" as a library, for which we add dedicated support. See this PR as an example: Add MeshAnything library huggingface/huggingface.js#784
  2. one could leverage the PyTorchModelHubMixin which is a minimal class which can be added to any nn.Module, to add from_pretrained and push_to_hub capabilities. This ensures the safer safetensors format is leveraged.

Improve discoverability

Besides making download stats work, we could also help in improving the discoverability of your models on the hub. We can for instance add appropriate tags to the model repos (READMEs) such as text-to-video which allow people to find your models.

Let me know what you prefer, and whether you need any help regarding this!

Cheers,

Niels
ML Engineer @ HF 🤗

@NielsRogge
Copy link
Author

Opened huggingface/huggingface.js#805 for download stats

@NielsRogge
Copy link
Author

Hi @scutpaul would you be able to merge the PRs mentioned here?

This will ensure download stats work for your models on HF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant