Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle units handling #1974

Open
zicher3d opened this issue Aug 16, 2024 · 0 comments
Open

Angle units handling #1974

zicher3d opened this issue Aug 16, 2024 · 0 comments

Comments

@zicher3d
Copy link

There are a few issues I'd like to clarify in this posting.

First, if you open the mtlx in the attached zip, you are greeted by an error:
unit_test.zip
image

While the error mentions meters, the line causing the issue is line #6 where the angle input is specified.
My understanding is that it's trying to convert the angle to meters.

Adding a unit attribute (like in the commented line #8) gets rid of the error and everything seem to work.

My concern is that, if I were to do something similar to the input above it (line #5, where I use "distance") and add a unit attribute there, when I check the material in Viewer and change the scene units in the Advanced Settings, the size does not adjust automatically any more.

I am not sure the unit attribute should be in the nodedef, and other libraries seem to only use the unittype there. But since I had to add it to the angle input, I'm afraid that might prevent the automatic scaling of the angle as it does for distances.

One other thing missing is that the Viewer allows us to change the distance units, but not the Angle one. If the above issue gets resolved we would need that to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant