Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaults should publish Director's governed params more conveniently #10094

Open
Chris-Hibbert opened this issue Sep 16, 2024 · 0 comments
Open
Assignees
Labels
contract-upgrade deployment Chain deployment mechanism (e.g. testnet) enhancement New feature or request Governance Governance hygiene Tidying up around the house

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

When upgrading the VaultFactory, it's necessary to retrieve the governed parameters from the old version, since the paramManager is not durable, and resets. The parameters from the individual vaultManagers are available via call on the director's publicFacet, but the director's top-level governed params are only published via a notifier and to vstorage, which are more work to retrieve during upgrade.

E(directorPF).getGovernedParams({ collateralBrand });

Description of the Design

Add a method to the publicFacet.

Security Considerations

These parameters are all published already, so there's no security exposure in revealing them more conveniently.

Scaling Considerations

None

Test Plan

simple regression tests.

Upgrade Considerations

simplifies upgrade

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request deployment Chain deployment mechanism (e.g. testnet) hygiene Tidying up around the house Governance Governance contract-upgrade labels Sep 16, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade deployment Chain deployment mechanism (e.g. testnet) enhancement New feature or request Governance Governance hygiene Tidying up around the house
Projects
None yet
Development

No branches or pull requests

1 participant