Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream new coins utilities #4572

Closed
JimLarson opened this issue Feb 17, 2022 · 1 comment
Closed

Upstream new coins utilities #4572

JimLarson opened this issue Feb 17, 2022 · 1 comment
Assignees
@JimLarson
Labels
agoric-cosmos enhancement New feature or request
Milestone
Mainnet 1 RC0

Comments

@JimLarson
Copy link
Contributor

We've produced useful utilities for managing sdk.Coins in the cosmos-sdk, and we can help the community by contributing them. We'll also help our own development and maintenance burden.

The utilities were developed as part of the standalone lien work: https://github.com/Agoric/agoric-sdk/blob/3991-standalone-loc/golang/cosmos/types/coin.go#L38

  • Min and Max operations with lattice/multiset semantics
  • A non-panicking equality test
  • Guidance on safe operations in the cosmos-sdk
  • Algebraic properties among the operations

See also #557 for isomorphic JS issues.
@JimLarson JimLarson added agoric-cosmos enhancement New feature or request labels Feb 17, 2022
@JimLarson JimLarson self-assigned this Feb 17, 2022
@JimLarson
Copy link
Contributor Author

Upstreaming Min and Max operations

@JimLarson JimLarson mentioned this issue Feb 23, 2022
Merged
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimLarson JimLarson

Labels
agoric-cosmos enhancement New feature or request
Projects
None yet
Milestone
Mainnet 1 RC0
Development

No branches or pull requests
2 participants
@Tartuffo @JimLarson