Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Schall Suit mod instead of having own custom armor #9

Open
Stargateur opened this issue Sep 29, 2022 · 2 comments · May be fixed by #10
Open

Use Schall Suit mod instead of having own custom armor #9

Stargateur opened this issue Sep 29, 2022 · 2 comments · May be fixed by #10

Comments

@Stargateur
Copy link
Contributor

I propose to use Schall Suit mod as a dep. This has several benefit:

  • reduce maintenance of this mod
  • reduce bloat of this mod (not need to have 2 armor that only exist for early)
  • basic shall suit purpose follow this mod purpose to limit use of this equipment to early armor
  • Make use of common mod that define armor, Schall suit is a nice mod to use if a mod add equipment design for engineer stuff. This add a little difficulty cause with Schall suit you don't have much combat capability like reduce damage. For user this is a nice quality of life in case you want use schall suit and early construction mod.
@Stargateur Stargateur linked a pull request Sep 29, 2022 that will close this issue
2 tasks
@Aidiakapi
Copy link
Owner

I'm not interested in adding (non-lib) required dependencies to this mod, since it is a QoL mod that has as specific goal to be compatible with vanilla and any modpack. Forcing users to adopt another mod for this one to function is counterproductive.

It is potentially interesting to add compatibility with other mods, if it's beneficial, however, I'd first need to research them, for which I lack the time at the moment. I'll leave this issue open for now, until I have a moment to do the research.

@Stargateur
Copy link
Contributor Author

So, something like optional dep would be ok ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants