Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments "silently" fail after v4 update: remote: Pushed to branch other than [main, master], skipping build. #176

Open
viamin opened this issue Apr 14, 2024 · 3 comments

Comments

@viamin
Copy link

viamin commented Apr 14, 2024

I'm seeing this in my Github Action output after updating to v4:

STEP: Adding Remote - Success
STEP: Adding Configuration Variables from env and envfile - Success
remote: Pushed to branch other than [main, master], skipping build.        
To https://git.heroku.com/myapp-production.git
   5f84f2f7..62b983be  main -> refs/head/main
STEP: Deploying - Success
default: PASSED Application is running (0.000s)
STEP: Performing HealthCheck - Success

This is (basically) what my deployment workflow step looks like:

  deploy-production:
    needs: [test, lint, deploy-staging]
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - name: Deploy Production
        uses: akhileshns/heroku-deploy@v4
        with:
          heroku_app_name: "myapp-production"
          heroku_email: "<my email>"
          heroku_api_key: "${{secrets.HEROKU_API_KEY}}"
          healthcheck: "https://myapp.com/okcomputer"
          delay: 20
          rollbackonhealthcheckfailed: true

Rolling back to uses: akhileshns/[email protected] with otherwise the same configuration above works as expected.

@karlentwistle
Copy link

karlentwistle commented Apr 15, 2024

Also facing the same problem switching from 3.13.15 to 4

remote: Pushed to branch other than [main, master], skipping build. 
  deploy:
    runs-on: ubuntu-latest
    concurrency: production-deploy
    steps:
      - uses: actions/checkout@v4
      - uses: akhileshns/heroku-deploy@v4
        with:
          heroku_email: ${{ secrets.HEROKU_DEPLOY_USER }}
          heroku_api_key: ${{ secrets.HEROKU_DEPLOY_KEY }}
          heroku_app_name: "myapp-production"

and also found rolling back to uses: akhileshns/[email protected] with otherwise the same configuration above works as expected.

@kapso
Copy link

kapso commented Apr 15, 2024

seeing same issue

@heliosam
Copy link

It looks like v4 hasn't been published yet... for some reason dependabot is picking this version up wrongly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants