Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a VecDeque as the backend for Iter #8

Closed
Anders429 opened this issue Feb 18, 2021 · 0 comments · Fixed by #11
Closed

Use a VecDeque as the backend for Iter #8

Anders429 opened this issue Feb 18, 2021 · 0 comments · Fixed by #11
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
0.3.0

Comments

@Anders429
Copy link
Owner

As suggested in rust-lang/rust#27322 (comment), going from a Vec to a VecDeque should not allocate anything extra, meaning we could potentially use it as the backend for Iter and avoid shifting elements to the left every time we pop from the front.
@Anders429 Anders429 added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2021
@Anders429 Anders429 added this to the 0.3.0 milestone Feb 18, 2021
@Anders429 Anders429 linked a pull request Feb 18, 2021 that will close this issue
Use VecDeque in Iter. #11
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Use VecDeque in Iter. Anders429/nested_containment_list
1 participant
@Anders429