Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with UnionLib #447

Open
tyra314 opened this issue Oct 3, 2022 · 2 comments
Open

Incompatibility with UnionLib #447

tyra314 opened this issue Oct 3, 2022 · 2 comments
Labels
mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version type: crash The game is crashing. Sad times. type: mod interaction An issue in conjunction with another mod version: 1.18

Comments

@tyra314
Copy link
Member

tyra314 commented Oct 3, 2022

Unionlib adds basically the same mixin as the StructureStartMixin, which uses @Redirect. If only these were injects instead.

@tyra314 tyra314 added type: mod interaction An issue in conjunction with another mod mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version version: 1.18 type: crash The game is crashing. Sad times. labels Oct 3, 2022
@MattyIceee
Copy link

any idea's of a fix for this. not familiar enough with that lib to try and make it myself 😢

@tyra314
Copy link
Member Author

tyra314 commented Nov 12, 2022

The situation is quite difficult with no clear path forward. The underlying issue is that both AA and UnionLib add virtually the same mixin, but use the @Redirect mixin type to do so. The thing is, only one such mixin is allowed. For the interested, look here. The mixin is used during world gen to generate an event for all parts of larger structures, such as villlages, nether fortress etc. It's used in AA to map out those structures.

There are a few options here:

  1. Change the implementation of the Mixin. I've checked that and I don't see a way to actually achieve that.
  2. Just be incompatible. That obviously sucks, but is more or less the status quo.
  3. Drop the Mixin. That's not possible at least for AA, as it is needed for village and nether fortress detection.
  4. Make AA depend on UnionLib and use its Mixin instead of AA's own one. That is best of all the bad options. However, it means people have to install one more dependencies making it even more complicated to use AA in the first place. People are already overwhelmed with the Architectury mod. So I'm hesitant to go there. Also, while I'm grateful to Stereowalker for the help to keep AA up to date in the past, UnionLib is a very generic helper mod stuffing various things he uses for his mods together. I'd be more inclined to depend on a library mod, which only purpose would be to provide things related to the one Mixin in question aka structure spawning / world gen stuff. And UnionLib isn't that. Also, to my knowledge, no such library exists, yet.

Since all options are bad, I've opted to do nothing about it right now.

@tyra314 tyra314 changed the title Incompatibility with UnionLib Incompatibility with UnionLib and Structure Gel API Jan 15, 2023
@tyra314 tyra314 changed the title Incompatibility with UnionLib and Structure Gel API Incompatibility with UnionLib Jan 15, 2023
@tyra314 tyra314 pinned this issue Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version type: crash The game is crashing. Sad times. type: mod interaction An issue in conjunction with another mod version: 1.18
Projects
None yet
Development

No branches or pull requests

2 participants