-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additionalProperties: true #589
Comments
Hi @thushalya - unlike OpenAPI, the AsyncAPI specification actually does not allow If you follow the link they include in that section to the My reading of this is that the current modeling in Apicurio Data Models v2 is correct. |
Hello @EricWittmann can you refer to this issue asyncapi/jasyncapi#131 in jasyncapi They have already changed it in jasyncapi latest model |
Ah ha - that's a subtlety of the JSON schema spec I didn't realize, namely that My mind is blown. It's easy enough to fix, fortunately. Do you want to give it a shot or wait for me? :) All you would need to do is change the descriptions in the spec yaml files. For example, this must be changed: And should become this: Then rebuild and see if anything breaks. Note: you would need to make the above change in all of the AsyncAPI yaml files. |
@EricWittmann Yeah definitely I will do it. |
Fixed in #595 |
Since additionalProperties variable is using AsyncApiSchema type , cannot give the value as true when it comes to create schema for
map<json>
Here json will be dynamic. Isn't it good to have it as the type of Object in java.. Or is there any way to set this please point out to me . Thank you
The text was updated successfully, but these errors were encountered: