Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logfile corruption #1006

Open
uli42 opened this issue Mar 6, 2021 · 6 comments
Open

logfile corruption #1006

uli42 opened this issue Mar 6, 2021 · 6 comments

Comments

@uli42
Copy link
Member

uli42 commented Mar 6, 2021

When enabling DEBUG in Compext.c an Clipboard.c the logfile seems to get corrupted. Norm Green saw this:

I can see from /proc that there are 3 different file descriptors open
for the log file session.log: 2 (stderr), 6 and 11.
I suspect there is some thread-unsafe behavior causing overwrites.

and

Sorry, that's all there is. It was 20 gb (!) in size most of which was
binary 0s for some reason.
The current log is already 8 GB and is also mostly binary 0s.

@uli42
Copy link
Member Author

uli42 commented Mar 7, 2021

A suspended session has only file descriptors while a running session has three.

@uli42
Copy link
Member Author

uli42 commented Mar 7, 2021

The third fd appearing after a reconnect is the one that is referred to by the errors= parameter of the options file.

@uli42
Copy link
Member Author

uli42 commented Mar 7, 2021

x2gostartagent defines a SESSION_LOG which is used both for the x2goagent errors file (errors= in the options file) and the redirection of stderr. In addition nxagent clones stderr's file descriptor to be used as the clients log file (which would be clients= in the options file but is only used during startup and the overwritten by stderr).

@lkraav
Copy link

lkraav commented Mar 8, 2021

Yes, I can see such a logfile in my current session, 8G large already. Is this still an issue in nx-3.5.99.26? From forum, it seemed like .26 would resolve it.

@uli42
Copy link
Member Author

uli42 commented Mar 8, 2021 via email

@uli42
Copy link
Member Author

uli42 commented Dec 22, 2021

This is a bug in x2goserver which is tracked here: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1537

A fix has been applied an will be included in the next release (4.1.0.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants