Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate Dockfile in the root directory #260

Open
qifeng-bai opened this issue Aug 15, 2024 · 1 comment
Open

Relocate Dockfile in the root directory #260

qifeng-bai opened this issue Aug 15, 2024 · 1 comment
Assignees

Comments

@qifeng-bai
Copy link
Contributor

I noticed that the Dockerfile is located in the root directory of the repository (https://github.com/AtlasOfLivingAustralia/alerts/blob/develop/Dockerfile). We also have a docker-compose file under the docker directory, which is used for building the local development environment.

I believe that the Dockerfile in the root directory is intended for the AWS pipeline. To avoid confusion, should we consider moving it to a cicd folder? Alternatively, we could establish a best practice for the project structure.

@joe-lipson
Copy link
Contributor

That sounds good about establishing a best practice for this. Ideally we'd be looking at having a common Docker file for AWS and what is used locally, maybe it all lives in the docker directory? I dont know enough about how this all fits together to have an opinion on exactly how we do it but I'd like to be in the discussion @hamzajaved-csiro should be a part of this too. I can set something up .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants