Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download emails have invalid URL for DOI links #913

Open
nickdos opened this issue Aug 21, 2024 · 0 comments
Open

Download emails have invalid URL for DOI links #913

nickdos opened this issue Aug 21, 2024 · 0 comments
Labels

Comments

@nickdos
Copy link
Contributor

nickdos commented Aug 21, 2024

Biocache-service generates the download email via a download-email.html template file. There are 2 versions of the DOI link provided in the email, one for the ALA's DOI service (doi.ala.org.au) and the other is the canonical DOI link (doi.org).

The canonical version is currently broken due to containing an internal space character in the URL and thus is not clickable. Its being populated by the variable officialDoiUrl, which appears to have the host component populated by a config var of official.doi.resolver.

The DOI for this download is https://doi.org /10.26197/ala.0afdc816-ecfa-4a2f-b65f-d269521373e8

The space is just after the doi.org string and comes through as encoded space %20 - https://doi.org%20/10.26197/ala.0afdc816-ecfa-4a2f-b65f-d269521373e8

Fix is to remove this space from the variable assignment or config value (official.doi.resolver most likely).

@nickdos nickdos added the bug label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant