Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the size of text in Twitter embeds #709

Open
tylerknott opened this issue May 20, 2020 · 1 comment
Open

Override the size of text in Twitter embeds #709

tylerknott opened this issue May 20, 2020 · 1 comment

Comments

@tylerknott
Copy link

tylerknott commented May 20, 2020

It looks like Twitter is rolling out a new style of embed that has much larger text than the previous style. I set my font size for threads to 12 and it looks like Twitter is somewhere around 20 or 22 which is comically large in comparison: https://i.imgur.com/kst6dbj.png

Ideally the font size for the body of the Tweet and display name of the Tweeter would be the same as the font size of the thread text and the other text in the Tweet would maybe be a size or two down from that.

@baka-kaba
Copy link
Contributor

Yeah I've seen that happen, looks kinda bad!
Unfortunately we don't really have any control over that, there's a script from Twitter that runs and embeds all their html and css, so they're responsible for what the contents look like - and as far as I'm aware there's no "max font size" styling we can force for the whole page.

It would probably be possible to run another pass once the embedding has completed, and rewrite all the font sizes, but then we're getting into janitoring someone else's content (which they're messing with themselves right now) and adding another layer of complexity and the chance to break things

Personally I don't really want to touch it if I can help it, @Sereri might though, being the resident javascript wrangler??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants