Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin _artifactsLocation to a git tag #3

Open
ItalyPaleAle opened this issue Feb 14, 2019 · 0 comments
Open

Pin _artifactsLocation to a git tag #3

ItalyPaleAle opened this issue Feb 14, 2019 · 0 comments

Comments

@ItalyPaleAle
Copy link
Member

Currently, the default value for _artifactsLocation is https://raw.githubusercontent.com/Azure/LAMP/master/.

We should start tagging "versions" of this template, possibly following semver, and "pin" the version to a git tag.

This is important because if customers deploy the template and we make some changes to the bash scripts (not the templates themselves) in master, then VMs in the VMSS would always pick up the scripts from master, which might break the deployment.

(A second thing we should do is to recommend customers to copy the scripts in their storage accounts too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant