Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove double "operations" in operation group names #910

Closed
iscai-msft opened this issue Mar 29, 2021 · 1 comment
Closed

remove double "operations" in operation group names #910

iscai-msft opened this issue Mar 29, 2021 · 1 comment
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. p0

Comments

@iscai-msft
Copy link
Contributor

iscai-msft commented Mar 29, 2021

In the case of "DeploymentOperationsOperations", we should only have one Operations.

Don't really believe this is breaking, treating it more like a bug fix. This only impacts the class name of the operation group (which is technically public, but users shouldn't instantiate them), and the filename that this operation group is stored in (which is private). The operation group property on the service client stays the same

@iscai-msft iscai-msft changed the title remove double "operations" in oepration group names remove double "operations" in operation group names Mar 29, 2021
@iscai-msft iscai-msft self-assigned this Mar 29, 2021
@iscai-msft iscai-msft added p0 bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Mar 29, 2021
@iscai-msft
Copy link
Contributor Author

Decided not to make this fix after talking to @lmazuel . Reasons are:

  1. users should never care about the operation group class name. They should only interact with the attributes on the service client, whose name is currently correct, so this change doesn't add any customer value.
  2. This could cause errors when there didn't use to be any. Say, if a swagger defines operation groups Deployment and DeploymentOperations. Now, we create both operation groups with the same name, which will cause issues.

Thus, we're not making this change because there's not any customer improvement, and it opens us up to potential issues in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. p0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant