Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DedicatedHostGroup.properties.supportAutomaticPlacement default to false #16077

Closed
dochung4 opened this issue Nov 29, 2020 · 7 comments · Fixed by #16168
Closed

Make DedicatedHostGroup.properties.supportAutomaticPlacement default to false #16077

dochung4 opened this issue Nov 29, 2020 · 7 comments · Fixed by #16168
Assignees
@qwordy
Labels
Compute az vm/vmss/image/disk/snapshot feature-request Service Team Support Request
Milestone
S180

Comments

@dochung4
Copy link

Resource Provider

Microsoft.Compute

Description of Feature or Work Requested

The initial plan was to default DedicatedHostGroup.properties.supportAutomaticPlacement to true, but recently we have agreed to default the value to false as we GA. The change to default to false has already been made on the service side.

Minimum API Version Required

2020-06-01

Swagger Link

Azure/azure-rest-api-specs#11697

Target Date

The feature is expected to GA on December 10. While having a wrong description is not the biggest issue, it would be good to have this change reflected in the next release.
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2020
@yungezz yungezz added the Compute az vm/vmss/image/disk/snapshot label Nov 30, 2020
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Nov 30, 2020
@yungezz yungezz added this to the S179 milestone Nov 30, 2020
@yungezz
Copy link
Member

yungezz commented Nov 30, 2020

hi @qwordy could you pls take care of the change? thanks

@qwordy
Copy link
Member

qwordy commented Nov 30, 2020

OK

@dochung4
Copy link
Author

dochung4 commented Dec 7, 2020

OK

@qwordy , can you please review?

@qwordy qwordy mentioned this issue Dec 7, 2020
Merged
3 tasks
@qwordy
Copy link
Member

qwordy commented Dec 7, 2020

The change will be released on 12/29/2020. Sorry it is a bit late than your GA date.

@dochung4
Copy link
Author

dochung4 commented Dec 7, 2020

The change will be released on 12/29/2020. Sorry it is a bit late than your GA date.

Thank you Feiyue. This is only for updating the description, so a slight delay should be fine. Can you please approve the PR and merge it, if the change looks fine?

@yungezz yungezz modified the milestones: S179, S180 Dec 8, 2020
@qwordy
Copy link
Member

qwordy commented Dec 8, 2020

OK.

A review comment:

this will be a behavior breaking change to users, although no CLI interface breaking. What's service side communication plan?

@dochung4
Copy link
Author

dochung4 commented Dec 8, 2020

OK.

A review comment:

this will be a behavior breaking change to users, although no CLI interface breaking. What's service side communication plan?

This feature has been in preview with limited subscriptions, so the impact of this change should be minimal. Also, there will be a blog post about this as we GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwordy qwordy

Labels
Compute az vm/vmss/image/disk/snapshot feature-request Service Team Support Request
Projects
None yet
Milestone
S180
Development

Successfully merging a pull request may close this issue.

{Compute} vm host group: --automatic-placement default value qwordy/azure-cli
3 participants
@qwordy @yungezz @dochung4