Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure CLI, DNS: An Upper.Case zone name is concatenated to the record name, causing duplication #7907

Closed
zvargams opened this issue Nov 22, 2018 · 4 comments · Fixed by #12264
Assignees
Labels
Network - DNS az network dns Network az network vnet/lb/nic/dns/etc...
Milestone

Comments

@zvargams
Copy link

Describe the bug
When the Azure CLI DNS import command is called with a zone name containing Upper.Case.Letters, then the zone name is concatenated to the record name, causing duplication.

To Reproduce
Import a zone with:

az network dns zone import --resource-group xxx --name Test.Zone

will import / create the following records:

(1/27) Imported 1 records of type 'soa' and name 'test.zone'
(2/27) Imported 1 records of type 'a' and name 'test.zone'
(3/27) Imported 1 records of type 'mx' and name 'test.zone'
(8/27) Imported 5 records of type 'txt' and name 'test.zone'
(9/27) Imported 1 records of type 'cname' and name '*.test.zone' 

while with all lower case:

az network dns zone import --resource-group xxx --name test.one

does import it properly:

(1/27) Imported 1 records of type 'soa' and name '@'
(2/27) Imported 1 records of type 'a' and name '@'
(3/27) Imported 1 records of type 'mx' and name '@'
(8/27) Imported 5 records of type 'txt' and name '@'
(9/27) Imported 1 records of type 'cname' and name '*'

Expected behavior
DNS is case insensitive, therefore having upper or lower case letters in the zone name should not lead to different behaviors / results.

Environment summary
Windows 10

az --version
azure-cli (2.0.28)

Python (Windows) 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 17:54:52) [MSC v.1900 32 bit (Intel)]

@muwaqar
Copy link
Contributor

muwaqar commented Nov 23, 2018

Please assign to @karravi-msft.

@mmyyrroonn
Copy link
Contributor

@karravi-msft Hello. Any update?

@haroldrandom haroldrandom added the Network - DNS az network dns label Oct 25, 2019
@yonzhan yonzhan added this to the S164 milestone Dec 9, 2019
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 9, 2019

add to S164.

@mmyyrroonn
Copy link
Contributor

@zvargams Thanks for this issue. I think your suggestion should be right. However, there are existing users using this command. This would be a breaking change for them. So I added warning information first and open another issue to track it. This would be fixed months later. Thanks.

@yonzhan yonzhan modified the milestones: S167, S166 Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Network - DNS az network dns Network az network vnet/lb/nic/dns/etc...
Projects
None yet
7 participants