Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new parameters into az network watcher connection-monitor. Add new commands. #9432

Closed
irrogozh opened this issue May 17, 2019 · 10 comments · Fixed by #12078 or #12140
Closed
Assignees
Labels
Network - Network Watcher az network watcher Network az network vnet/lb/nic/dns/etc... New Command(s)
Milestone

Comments

@irrogozh
Copy link
Member

irrogozh commented May 17, 2019

Resource Provider
Az.Network

Description of Feature or Work Requested
We are going to create a new version of connection monitor API. instead of single source/destination we are going to enable monitoring for multiple endpoints and configurations. Instead of current parameters, we will need to have a list of endpoints, testConfigurations, testGroups and outputs.

Looks like reasonable approach:

  1. create a shallow connection monitor resource:
    az network watcher connection-monitor create --name --notes

  2. add endpoint to connection monitor:
    az network watcher connection-monitor endpoint create --name --resourceId --address --filterType --filterAddresses

  3. add testConfiguration to connection monitor:
    az network watcher connection-monitor testConfiguration create --name --testFrequencySec -- successThresholdChecksFailedPercent --successThresholdRoundTripTimeMs --preferredIPVersion --protocolConfiguration

  4. add testGroup to connection monitor:
    az network watcher connection-monitor testGroup create --name --testConfigurations(list of test configuration names) --sources(list of source endpoint names) --destinations(list of destination endpoint names)

  5. add output to connectionMonitor:
    az network watcher connection-monitor output create --outputType --workspaceResourceId

  6. I'm not sure what's the best approach to set protocolConfiguration from item 3.
    For powershell we do it like this:

New-AzNetworkWatcherConnectionMonitorProtocolConfigurationObject -Protocol

[1st parameter set - if TCP protocol specified: [-Port] [-DisableTraceRoute]]
[2nd parameter set - if HTTP protocol specified: [-Port] [-Method] [-Path] [-RequestHeader] [-ValidStatusCodeRange<List[String]>] [-PreferHTTPS]]
[3nd parameter set - if ICMP protocol specified: [-DisableTraceRoute]]


  1. We also need to have some way to update connection monitor. If there is an option to delete endpoint, testConfiguration, testGroup and output from connectionMonitor, it could work. The challenge is that if customer remove endpoint but forget to remove this endpoint name from a testGroup which was referenced it, customer will have validation exception on server side. Probably, it's fine...

Minimum API Version Required
What is the minimum API version of your service required to implement your feature?

Swagger Link
Azure/azure-rest-api-specs#7821

it's not updated with new parameters yet

Target Date
We are going to have private preview at the second half of June.

@irrogozh irrogozh changed the title Introduce new parameters into az network watcher connection-monitor Introduce new parameters into az network watcher connection-monitor. Add new commands. May 17, 2019
@adewaleo adewaleo added Feature Network az network vnet/lb/nic/dns/etc... New Command(s) labels May 20, 2019
@tjprescott
Copy link
Member

@irrogozh what is the min API version for these features and are there PRs that show the actual swagger changes?

@tjprescott tjprescott added this to the Sprint 64 milestone May 20, 2019
@tjprescott tjprescott modified the milestones: Sprint 64, Sprint 65 May 30, 2019
@tjprescott
Copy link
Member

Bumping to sprint 66 due to higher priority direction from NRP.

@tjprescott tjprescott modified the milestones: Sprint 65, Sprint 66 Jun 17, 2019
@irrogozh irrogozh changed the title Introduce new parameters into az network watcher connection-monitor. Add new commands. DO NOT IMPLEMENT THIS YET: Introduce new parameters into az network watcher connection-monitor. Add new commands. Jun 17, 2019
@irrogozh
Copy link
Member Author

Travis, please, don't implement this please. The spec is not approved yet - there is ongoing changes in contract...

@tjprescott
Copy link
Member

@irrgozh no worries. If the spec isn't approved for work in sprint 66 I'll just shuffle priorities accordingly.

@tjprescott tjprescott removed their assignment Jul 29, 2019
@mmyyrroonn
Copy link
Contributor

@irrogozh Hello. Once are the spec PR ready, please modify the title and ping me. Thanks

@mmyyrroonn
Copy link
Contributor

@irrogozh Feel free to ping me when the service's ready.

@mmyyrroonn mmyyrroonn modified the milestones: S162, Backlog Dec 2, 2019
@irrogozh irrogozh changed the title DO NOT IMPLEMENT THIS YET: Introduce new parameters into az network watcher connection-monitor. Add new commands. Introduce new parameters into az network watcher connection-monitor. Add new commands. Dec 3, 2019
@irrogozh
Copy link
Member Author

irrogozh commented Dec 3, 2019

@myronfanqiu , can we discuss design? The public preview is going to be in January. So, we will need to have cmdlets by this time.

@mmyyrroonn
Copy link
Contributor

@irrogozh sure. Should we schedule a meeting?

@irrogozh
Copy link
Member Author

irrogozh commented Dec 3, 2019

@myronfanqiu, yep, would be great. Could you send me your Msft alias so I could schedule a meeting? What time would be convenient for you? I'm working on PST time...
Just in case, my alias - irrogozh@microsoft.com

@haroldrandom haroldrandom added Feature Request Network az network vnet/lb/nic/dns/etc... Network - Network Watcher az network watcher and removed Feature labels Dec 4, 2019
@haroldrandom haroldrandom self-assigned this Dec 4, 2019
@yonzhan yonzhan modified the milestones: Backlog, S164 Dec 30, 2019
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 30, 2019

add to S164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Network - Network Watcher az network watcher Network az network vnet/lb/nic/dns/etc... New Command(s)
Projects
None yet
6 participants