Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Insights ScheduledQueryRuleProperties/actions has invalid type #15588

Closed
anthony-c-martin opened this issue Aug 9, 2021 · 4 comments
Closed

Microsoft.Insights ScheduledQueryRuleProperties/actions has invalid type #15588

anthony-c-martin opened this issue Aug 9, 2021 · 4 comments
Assignees
@avjerafi
Labels
Insights Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@anthony-c-martin
Copy link
Member

See definition for /specification/monitor/resource-manager/Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json#/definitions/ScheduledQueryRuleProperties/actions:

azure-rest-api-specs/specification/monitor/resource-manager/Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json

Lines 411 to 417 in 7384176

"actions": {
"type": "object",
"items": {
"$ref": "#/definitions/Actions"
},
"description": "Actions to invoke when the alert fires."
},

Generally, "items" is only used with an "array" type. Should we have "type": "array" here?

Originally raised under Azure/bicep#3806
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 9, 2021
@raych1 raych1 added Insights Service Attention Workflow: This issue is responsible by Azure service team. labels Aug 18, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 18, 2021
@raych1
Copy link
Contributor

raych1 commented Aug 18, 2021

@avjerafi , can you have a look at this issue since you were working on this swagger?

@avjerafi
Copy link
Contributor

@raych1
We have already caught this and the fix was merged 6 days ago:
Please see: #15607

@JackTn
Copy link
Member

JackTn commented Dec 23, 2021

@anthony-c-martin hi ~ is this issue resolved? And can you closed if it meets your expectations， thanks

@anthony-c-martin
Copy link
Member Author

Looks good, thanks for fixing @avjerafi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avjerafi avjerafi

Labels
Insights Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@raych1 @JackTn @anthony-c-martin @avjerafi