From 562d1e880ccf176c745722448826095f3e2215b2 Mon Sep 17 00:00:00 2001 From: David Han Date: Wed, 20 Jan 2021 15:58:23 -0800 Subject: [PATCH 1/6] add missing properties and response code --- .../stable/2016-05-16/analysisservices.json | 115 +++++++++++++++++ .../stable/2017-07-14/analysisservices.json | 102 +++++++++++++++ .../stable/2017-08-01/analysisservices.json | 118 ++++++++++++++++++ .../2017-08-01/examples/createServer.json | 27 ++++ 4 files changed, 362 insertions(+) diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json index 0475c9a7d800..f59e1c4592f1 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json @@ -129,6 +129,12 @@ "$ref": "#/definitions/AnalysisServicesServer" } }, + "202": { + "description": "Preparing. The operation is still completing.", + "schema": { + "$ref": "#/definitions/AnalysisServicesServer" + } + }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -569,6 +575,9 @@ "202": { "description": "Accepted. The operation is ongoing." }, + "204": { + "description": "No Content." + }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -708,6 +717,108 @@ "description": "The origin", "type": "string", "readOnly": true + }, + "properties":{ + "description": "Additional properties to expose performance metrics to shoebox.", + "properties": { + "serviceSpecification": { + "description": "Performance metrics to shoebox.", + "properties": { + "metricSpecifications": { + "description": "The metric specifications.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/MetricSpecifications" + } + }, + "logSpecifications": { + "description": "The log specifications.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/LogSpecifications" + } + } + } + } + } + } + } + }, + "MetricSpecifications": { + "description": "Available operation metric specification for exposing performance metrics to shoebox.", + "type": "object", + "properties": { + "name": { + "description": "The name of metric.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "The displayed name of metric.", + "type": "string", + "readOnly": true + }, + "displayDescription": { + "description": "The displayed description of metric.", + "type": "string", + "readOnly": true + }, + "unit": { + "description": "The unit of the metric.", + "type": "string", + "readOnly": true + }, + "aggregationType": { + "description": "The aggregation type of metric.", + "type": "string", + "readOnly": true + }, + "dimensions": { + "description": "The dimensions of metric.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/MetricDimensions" + } + } + } + }, + "LogSpecifications": { + "description": "The log metric specification for exposing performance metrics to shoebox.", + "type": "object", + "properties": { + "name": { + "description": "The name of metric.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "The displayed name of log.", + "type": "string", + "readOnly": true + }, + "blobDuration": { + "description": "The blob duration for the log.", + "type": "string", + "readOnly": true + } + } + }, + "MetricDimensions": { + "description": "Metric dimension.", + "type": "object", + "properties": { + "name": { + "description": "Dimension name.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "Dimension display name.", + "type": "string", + "readOnly": true } } }, @@ -1175,6 +1286,10 @@ "type": "integer", "format": "int32" }, + "timeStamp": { + "description": "the timestamp for the error.", + "type": "string" + }, "details": { "readOnly": true, "type": "array", diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json index 4e4fd668187d..abd9ba7049f6 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json @@ -803,6 +803,108 @@ "description": "The origin", "type": "string", "readOnly": true + }, + "properties":{ + "description": "Additional properties to expose performance metrics to shoebox.", + "properties": { + "serviceSpecification": { + "description": "Performance metrics to shoebox.", + "properties": { + "metricSpecifications": { + "description": "The metric specifications.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/MetricSpecifications" + } + }, + "logSpecifications": { + "description": "The log specifications.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/LogSpecifications" + } + } + } + } + } + } + } + }, + "MetricSpecifications": { + "description": "Available operation metric specification for exposing performance metrics to shoebox.", + "type": "object", + "properties": { + "name": { + "description": "The name of metric.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "The displayed name of metric.", + "type": "string", + "readOnly": true + }, + "displayDescription": { + "description": "The displayed description of metric.", + "type": "string", + "readOnly": true + }, + "unit": { + "description": "The unit of the metric.", + "type": "string", + "readOnly": true + }, + "aggregationType": { + "description": "The aggregation type of metric.", + "type": "string", + "readOnly": true + }, + "dimensions": { + "description": "The dimensions of metric.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/MetricDimensions" + } + } + } + }, + "LogSpecifications": { + "description": "The log metric specification for exposing performance metrics to shoebox.", + "type": "object", + "properties": { + "name": { + "description": "The name of metric.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "The displayed name of log.", + "type": "string", + "readOnly": true + }, + "blobDuration": { + "description": "The blob duration for the log.", + "type": "string", + "readOnly": true + } + } + }, + "MetricDimensions": { + "description": "Metric dimension.", + "type": "object", + "properties": { + "name": { + "description": "Dimension name.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "Dimension display name.", + "type": "string", + "readOnly": true } } }, diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json index 3de2bb748379..87c3ea24aa70 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json @@ -139,6 +139,12 @@ "$ref": "#/definitions/AnalysisServicesServer" } }, + "202": { + "description": "Preparing. The operation is still completing.", + "schema": { + "$ref": "#/definitions/AnalysisServicesServer" + } + }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -850,6 +856,108 @@ "description": "The origin", "type": "string", "readOnly": true + }, + "properties":{ + "description": "Additional properties to expose performance metrics to shoebox.", + "properties": { + "serviceSpecification": { + "description": "Performance metrics to shoebox.", + "properties": { + "metricSpecifications": { + "description": "The metric specifications.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/MetricSpecifications" + } + }, + "logSpecifications": { + "description": "The log specifications.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/LogSpecifications" + } + } + } + } + } + } + } + }, + "MetricSpecifications": { + "description": "Available operation metric specification for exposing performance metrics to shoebox.", + "type": "object", + "properties": { + "name": { + "description": "The name of metric.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "The displayed name of metric.", + "type": "string", + "readOnly": true + }, + "displayDescription": { + "description": "The displayed description of metric.", + "type": "string", + "readOnly": true + }, + "unit": { + "description": "The unit of the metric.", + "type": "string", + "readOnly": true + }, + "aggregationType": { + "description": "The aggregation type of metric.", + "type": "string", + "readOnly": true + }, + "dimensions": { + "description": "The dimensions of metric.", + "type": "array", + "readOnly": true, + "items": { + "$ref": "#/definitions/MetricDimensions" + } + } + } + }, + "LogSpecifications": { + "description": "The log metric specification for exposing performance metrics to shoebox.", + "type": "object", + "properties": { + "name": { + "description": "The name of metric.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "The displayed name of log.", + "type": "string", + "readOnly": true + }, + "blobDuration": { + "description": "The blob duration for the log.", + "type": "string", + "readOnly": true + } + } + }, + "MetricDimensions": { + "description": "Metric dimension.", + "type": "object", + "properties": { + "name": { + "description": "Dimension name.", + "type": "string", + "readOnly": true + }, + "displayName": { + "description": "Dimension display name.", + "type": "string", + "readOnly": true } } }, @@ -1143,6 +1251,9 @@ "type": "string", "description": "The UPN of the user. For example: johnsmith@contoso.com." }, + "default": [ + "*" + ], "description": "An array of administrator user identities." } } @@ -1157,6 +1268,9 @@ "$ref": "#/definitions/IPv4FirewallRule", "description": "The content of firewall rule." }, + "default": [ + "*" + ], "description": "An array of firewall rules." }, "enablePowerBIService": { @@ -1439,6 +1553,10 @@ "type": "integer", "format": "int32" }, + "timeStamp": { + "description": "the timestamp for the error.", + "type": "string" + }, "details": { "readOnly": true, "type": "array", diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/examples/createServer.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/examples/createServer.json index 8d1f0f227fb5..72104283a78c 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/examples/createServer.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/examples/createServer.json @@ -78,6 +78,33 @@ "testKey": "testValue" } } + }, + "202": { + "headers": {}, + "body": { + "id": "/subscriptions/613192d7-503f-477a-9cfe-4efc3ee2bd60/resourceGroups/TestRG/providers/Microsoft.AnalysisServices/servers/azsdktest", + "location": "West US", + "name": "azsdktest", + "properties": { + "asAdministrators": { + "members": [ + "azsdktest@microsoft.com", + "azsdktest2@microsoft.com" + ] + }, + "provisioningState": "Preparing", + "serverFullName": "asazure://nightly1.asazure-int.windows.net/azsdktest", + "state": "Preparing" + }, + "sku": { + "capacity": 1, + "name": "S1", + "tier": "Standard" + }, + "tags": { + "testKey": "testValue" + } + } } } } From d58525b3d89dcdcf5ae64f6a5f7146b9b7fbaaa5 Mon Sep 17 00:00:00 2001 From: David Han Date: Wed, 20 Jan 2021 16:09:44 -0800 Subject: [PATCH 2/6] remove default --- .../stable/2017-08-01/analysisservices.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json index 87c3ea24aa70..17efc5f38fb8 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json @@ -1251,9 +1251,6 @@ "type": "string", "description": "The UPN of the user. For example: johnsmith@contoso.com." }, - "default": [ - "*" - ], "description": "An array of administrator user identities." } } @@ -1268,9 +1265,6 @@ "$ref": "#/definitions/IPv4FirewallRule", "description": "The content of firewall rule." }, - "default": [ - "*" - ], "description": "An array of firewall rules." }, "enablePowerBIService": { From 4977c0cdbe3df165649fa332c0ddcee64c8ed9e8 Mon Sep 17 00:00:00 2001 From: David Han Date: Wed, 20 Jan 2021 16:25:35 -0800 Subject: [PATCH 3/6] add default --- .../stable/2017-08-01/analysisservices.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json index 17efc5f38fb8..0f452087e5cd 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json @@ -1251,6 +1251,7 @@ "type": "string", "description": "The UPN of the user. For example: johnsmith@contoso.com." }, + "default": [], "description": "An array of administrator user identities." } } @@ -1265,7 +1266,8 @@ "$ref": "#/definitions/IPv4FirewallRule", "description": "The content of firewall rule." }, - "description": "An array of firewall rules." + "description": "An array of firewall rules.", + "default":[] }, "enablePowerBIService": { "type": "boolean", From 37e6052c8e8e015fa0a5f2cfef0fb06f20679d94 Mon Sep 17 00:00:00 2001 From: David Han Date: Wed, 20 Jan 2021 16:30:48 -0800 Subject: [PATCH 4/6] Revert "add default" This reverts commit 4977c0cdbe3df165649fa332c0ddcee64c8ed9e8. --- .../stable/2017-08-01/analysisservices.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json index 0f452087e5cd..17efc5f38fb8 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json @@ -1251,7 +1251,6 @@ "type": "string", "description": "The UPN of the user. For example: johnsmith@contoso.com." }, - "default": [], "description": "An array of administrator user identities." } } @@ -1266,8 +1265,7 @@ "$ref": "#/definitions/IPv4FirewallRule", "description": "The content of firewall rule." }, - "description": "An array of firewall rules.", - "default":[] + "description": "An array of firewall rules." }, "enablePowerBIService": { "type": "boolean", From 98ab94a7f804de56a109e5cbdda503f1ed01e92d Mon Sep 17 00:00:00 2001 From: David Han Date: Wed, 20 Jan 2021 17:55:28 -0800 Subject: [PATCH 5/6] fix prettier --- .../stable/2016-05-16/analysisservices.json | 2 +- .../stable/2017-07-14/analysisservices.json | 2 +- .../stable/2017-08-01/analysisservices.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json index f59e1c4592f1..efbcdc97431e 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json @@ -718,7 +718,7 @@ "type": "string", "readOnly": true }, - "properties":{ + "properties": { "description": "Additional properties to expose performance metrics to shoebox.", "properties": { "serviceSpecification": { diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json index abd9ba7049f6..24667db47ee6 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json @@ -804,7 +804,7 @@ "type": "string", "readOnly": true }, - "properties":{ + "properties": { "description": "Additional properties to expose performance metrics to shoebox.", "properties": { "serviceSpecification": { diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json index 17efc5f38fb8..b2d1ec250567 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json @@ -857,7 +857,7 @@ "type": "string", "readOnly": true }, - "properties":{ + "properties": { "description": "Additional properties to expose performance metrics to shoebox.", "properties": { "serviceSpecification": { From 2b57eb35c00143343f7f3e77ab7c66e78963673a Mon Sep 17 00:00:00 2001 From: David Han Date: Wed, 20 Jan 2021 18:58:49 -0800 Subject: [PATCH 6/6] add readonly field --- .../stable/2016-05-16/analysisservices.json | 3 ++- .../stable/2017-08-01/analysisservices.json | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json index efbcdc97431e..a30a4a4ec095 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json @@ -1288,7 +1288,8 @@ }, "timeStamp": { "description": "the timestamp for the error.", - "type": "string" + "type": "string", + "readOnly": true }, "details": { "readOnly": true, diff --git a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json index b2d1ec250567..d00d561411cd 100644 --- a/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json +++ b/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json @@ -1549,7 +1549,8 @@ }, "timeStamp": { "description": "the timestamp for the error.", - "type": "string" + "type": "string", + "readOnly": true }, "details": { "readOnly": true,