Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check nolint comments #15173

Closed
catalinaperalta opened this issue Jul 27, 2021 · 1 comment · Fixed by #19373
Closed

Check nolint comments #15173

catalinaperalta opened this issue Jul 27, 2021 · 1 comment · Fixed by #19373
Assignees
@jhendrixMSFT
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@catalinaperalta
Copy link
Member

Go through and remove nolint comments.
@catalinaperalta catalinaperalta added Client This issue points to a problem in the data-plane of the library. Track2 Azure.Identity labels Jul 27, 2021
@catalinaperalta catalinaperalta changed the title [azidentity] Check nolint comments [armcore] Check nolint comments Jul 27, 2021
@catalinaperalta catalinaperalta mentioned this issue Jul 27, 2021
Merged
@RickWinter RickWinter added Mgmt This issue is related to a management-plane library. bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed Client This issue points to a problem in the data-plane of the library. Track2 labels Sep 13, 2021
@lirenhe
Copy link
Member

lirenhe commented Sep 17, 2021

@RickWinter, as there is only azcore now, will this be a task for Joel to handle? Please let me know if you need help on this. Thanks.

@lirenhe lirenhe added CodeGen Issues that relate to code generation and removed Mgmt This issue is related to a management-plane library. labels Sep 17, 2021
@RickWinter RickWinter added the Mgmt This issue is related to a management-plane library. label Jan 14, 2022
@jhendrixMSFT jhendrixMSFT added Azure.Core and removed ARM - Core CodeGen Issues that relate to code generation Mgmt This issue is related to a management-plane library. labels Apr 12, 2022
@jhendrixMSFT jhendrixMSFT assigned jhendrixMSFT and unassigned lirenhe Apr 12, 2022
@jhendrixMSFT jhendrixMSFT removed the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Apr 12, 2022
@jhendrixMSFT jhendrixMSFT changed the title [armcore] Check nolint comments Check nolint comments Apr 12, 2022
@RickWinter RickWinter added the Client This issue points to a problem in the data-plane of the library. label Jun 27, 2022
@jhendrixMSFT jhendrixMSFT mentioned this issue Oct 17, 2022
Merged
@RickWinter RickWinter added the feature-request This issue requires a new behavior in the product in order be resolved. label Oct 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: remove nolint comments jhendrixMSFT/azure-sdk-for-go
4 participants
@RickWinter @lirenhe @catalinaperalta @jhendrixMSFT