Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL-encode query params when creating a request #18809

Closed
jhendrixMSFT opened this issue Aug 8, 2022 · 2 comments · Fixed by #18810
Closed

URL-encode query params when creating a request #18809

jhendrixMSFT opened this issue Aug 8, 2022 · 2 comments · Fixed by #18810
Assignees
@jhendrixMSFT
Labels
Azure.Core

Comments

@jhendrixMSFT
Copy link
Member

URL-encode the nextLink value for a pageable operation as required.

Example value.
https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Consumption/usageDetails?$expand=meterDetails&$filter=properties/usageStart ge '2021-07-01' and properties/usageEnd lt '2022-07-02'&$top=2&api-version=2021-10-01&sessiontoken=&$skiptoken=ABC123&skiptokenver=v1&id=00000000-0000-0000-0000-000000000000
@jhendrixMSFT jhendrixMSFT self-assigned this Aug 8, 2022
@jhendrixMSFT jhendrixMSFT changed the title Check if a nextLink requires URL-encoding URL-encode query params when creating a request Aug 8, 2022
@jhendrixMSFT jhendrixMSFT mentioned this issue Aug 8, 2022
Merged
@jhendrixMSFT
Copy link
Member Author

Fixed in upcoming azcore@v1.1.2

@jhendrixMSFT jhendrixMSFT reopened this Aug 9, 2022
@jhendrixMSFT
Copy link
Member Author

After further discussion, we should not be URL-encoding the values in azcore. The service MUST send the URL pre-encoded. Will back out the change.

@jhendrixMSFT jhendrixMSFT mentioned this issue Aug 9, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

URL encode query parameters when creating a request jhendrixMSFT/azure-sdk-for-go
1 participant
@jhendrixMSFT