Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support domain_hint in aad-starter #21517

Closed
2 tasks done
glyoder opened this issue May 14, 2021 · 3 comments · Fixed by #22134
Closed
2 tasks done

[Feature Request] Support domain_hint in aad-starter #21517

glyoder opened this issue May 14, 2021 · 3 comments · Fixed by #22134
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@glyoder
Copy link

glyoder commented May 14, 2021

Query/Question
I'm using the azure-spring-boot-starter-active-directory library to use azure active directory for login. But I need to pass a domain hint to the authorization url. Unforunately the authorization endpoint is hardcoded in AADAuthorizationServerEndpoints -- is there some way to override this that I'm missing?

Why is this not a Bug or a feature Request?
There may be a simple way to do this that I'm not aware of.

Setup (please complete the following information if applicable):

  • OS: Linux
  • IDE : IntelliJ
  • Version of the Library used: 3.4.0

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Query Added
  • Setup information Added
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 14, 2021
@joshfree joshfree added azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. labels May 17, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 17, 2021
@joshfree
Copy link
Member

@stliu could you follow up with @glyoder

@chenrujun chenrujun added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 19, 2021
@chenrujun chenrujun modified the milestones: [2021] July, [2021] August May 19, 2021
@chenrujun
Copy link

Hi, @glyoder .
Thanks for reaching out.

  1. Now azure-spring-boot-starter-active-directory does not support domain hint.
  2. But azure-spring-boot-starter-active-directory-b2c supports domain hint.

My current plan is to implement this feature before 2021-08-06 (Milestone: [2021] August).
I will very appreciate it if you can create a PR.

Refs:

  1. azure-spring-boot-starter-active-directory-b2c supports domain hint:
    1.1. https://github.com/Azure/azure-sdk-for-java/tree/azure-spring-boot-starter-active-directory-b2c_3.4.0/sdk/spring/azure-spring-boot-starter-active-directory-b2c#configure-and-compile-your-app
    1.2. https://github.com/Azure/azure-sdk-for-java/blob/azure-spring-boot-starter-active-directory-b2c_3.4.0/sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/autoconfigure/b2c/AADB2CProperties.java#L89
    1.3. https://github.com/Azure/azure-sdk-for-java/blob/azure-spring-boot-starter-active-directory-b2c_3.4.0/sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/autoconfigure/b2c/AADB2CAuthorizationRequestResolver.java#L87

  2. If we need to let azure-spring-boot-starter-active-directory supports domain hint:
    2.1. https://github.com/Azure/azure-sdk-for-java/blob/azure-spring-boot-starter-active-directory-b2c_3.4.0/sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/autoconfigure/aad/AADAuthenticationProperties.java
    2.2. https://github.com/Azure/azure-sdk-for-java/blob/azure-spring-boot-starter-active-directory-b2c_3.4.0/sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/webapp/AADOAuth2AuthorizationRequestResolver.java#L21

@chenrujun chenrujun changed the title [QUERY] Can I add a domain hint to the authorization endpiont? [Feature Request] Can I add a domain hint to the authorization endpiont? May 19, 2021
@chenrujun chenrujun changed the title [Feature Request] Can I add a domain hint to the authorization endpiont? [Feature Request] Support domain_hint in aad-starter May 19, 2021
@chenrujun chenrujun modified the milestones: [2021] August, [2021] July Jun 1, 2021
@chenrujun chenrujun linked a pull request Jun 9, 2021 that will close this issue
@chenrujun
Copy link

Closing this issue because related PR has been merged.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants