Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage][blob-batch] Getting TlsVersionNotPermitted with batch operations #11069

Closed
ljian3377 opened this issue Sep 7, 2020 · 5 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Milestone

Comments

@ljian3377
Copy link
Member

ljian3377 commented Sep 7, 2020

The test cases for batch operations fail on some storage accounts but succeeded on others.

it("deleteBlobs should work for batch delete", async () => {

Found in regression. And accroding to Ashish's comment in this .NET issue: Azure/azure-sdk-for-net#13524 (comment)
this is a bug on the service.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 7, 2020
@ljian3377 ljian3377 added Storage Storage Service (Queues, Blobs, Files) and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 7, 2020
@ljian3377
Copy link
Member Author

ljian3377 commented Sep 7, 2020

@jiacfan did some digging and found that the service may be working as designed.
The account has the "Mininum TLS version" set as "Version 1.2", which is the default in the portal when creating an account.

But how can a customer send TLS "Version 1.2" request with our SDK? I did some digging but failed to find a way.
@jeremymeng do we have support for specifying the TLS version?

@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Sep 8, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] October milestone Sep 8, 2020
@ramya-rao-a
Copy link
Contributor

But how can a customer send TLS "Version 1.2" request with our SDK

I doubt if a customer can do this.
@sarangan12 I recall you had done some investigation in this area. Can you share any details?

@ljian3377,
Can you share more details on how you encountered the failure?
Do you see this in CI or when you run manually?
Do you see it when using certain node versions?

@ljian3377
Copy link
Member Author

Can you share more details on how you encountered the failure?
Do you see this in CI or when you run manually?
Do you see it when using certain node versions?

I encountered this when testing manually at local. I created an account with "Mininum TLS version" set as "Version 1.2". I am using Node.js v12.18.4.
According to this comment, TLSv1.2 is the default TLS minimum? Then I don't know why it failed. How to find out which version we are acctually using.

nodejs/node#27666 (comment)

  --tls-max-v1.2                            set default TLS maximum to TLSv1.2 (default: TLSv1.3)
  --tls-max-v1.3                            set default TLS maximum to TLSv1.3 (default: TLSv1.3)
  --tls-min-v1.0                            set default TLS minimum to TLSv1.0 (default: TLSv1.2)
  --tls-min-v1.1                            set default TLS minimum to TLSv1.1 (default: TLSv1.2)
  --tls-min-v1.3                            set default TLS minimum to TLSv1.3 (default: TLSv1.2)

@jeremymeng jeremymeng modified the milestones: [2020] October, MQ-2020 Oct 13, 2020
@amishra-dev
Copy link

this should have been fixed by now. @ljian3377 can you confirm

@ljian3377
Copy link
Member Author

this should have been fixed by now. @ljian3377 can you confirm

Yes. The batch operations now work with an account whose "Mininum TLS version" is set as "Version 1.2".

@ramya-rao-a
I am fine with closing this issue if the support/documentation for specifying the TLS version can't be added.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

4 participants