Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Fix inconsistency in docstring and sample snippets #11684

Closed
yunhaoling opened this issue May 28, 2020 · 0 comments
Closed

[ServiceBus] Fix inconsistency in docstring and sample snippets #11684

yunhaoling opened this issue May 28, 2020 · 0 comments
Assignees
@yunhaoling
Labels
Client This issue points to a problem in the data-plane of the library. Docs Service Bus
Milestone
Backlog

Comments

@yunhaoling
Copy link
Contributor

yunhaoling commented May 28, 2020 •
edited by KieranBrantnerMagee
Loading

Need to go over every public API

  • compare the parameters -- add or remove
  • check code snippet part, whether the reference is correct

Callout for Management Models:

  • Needs to add ivar stanzas for each of the params we publicly expose (for e.g. AuthorizationRules)

See this comment #13552 (comment)
Determine if this is an issue that we should address broadly.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 28, 2020
@yunhaoling yunhaoling added Client This issue points to a problem in the data-plane of the library. Service Bus labels May 28, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 28, 2020
@yunhaoling yunhaoling changed the title [ServiceBus] Fix inconsistency in user error [ServiceBus] Fix inconsistency in docstring and sample snippets May 28, 2020
@yunhaoling yunhaoling added this to the [2020] July milestone May 28, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Jun 10, 2020
@KieranBrantnerMagee KieranBrantnerMagee mentioned this issue Sep 4, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yunhaoling yunhaoling

Labels
Client This issue points to a problem in the data-plane of the library. Docs Service Bus
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ramya-rao-a @KieranBrantnerMagee @yunhaoling