Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ExternalBearerTokenCredentialPolicy in azure-mgmt-core #17764

Closed
jsntcy opened this issue Apr 2, 2021 · 3 comments
Closed

Implement ExternalBearerTokenCredentialPolicy in azure-mgmt-core #17764

jsntcy opened this issue Apr 2, 2021 · 3 comments
Assignees
Labels
Azure.Mgmt.Core Azure management core issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library.

Comments

@jsntcy
Copy link
Member

jsntcy commented Apr 2, 2021

Is your feature request related to a problem? Please describe.
Customer wants to work around #8313 by adding a new custom policy called ExternalBearerTokenCredentialPolicy, but find it difficult.

Describe the solution you'd like
#16519

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jsntcy jsntcy added Mgmt This issue is related to a management-plane library. Azure.Mgmt.Core Azure management core labels Apr 2, 2021
@jiasli jiasli self-assigned this Apr 2, 2021
@jiasli
Copy link
Member

jiasli commented Apr 14, 2021

It is not easy to use this policy with Azure CLI dev branch because dev branch uses external_tenant_token_retriever to retrieve tokens for external tenants:

https://github.com/Azure/azure-cli/blob/039fa21db4fdf6dfb22958aaf1c3f614e1fc3b59/src/azure-cli-core/azure/cli/core/adal_authentication.py#L22

    def __init__(self, token_retriever, external_tenant_token_retriever=None):

Adopting this Track 2-compatible policy would require an overhaul of azure-cli-core to switch from external_tenant_token_retriever to external credentials. I prefer not to use this policy for Azure CLI dev, as this will be throw-away code.

@RAY-316 RAY-316 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hi @jsntcy. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost
Copy link

ghost commented Dec 29, 2021

Hi @jsntcy, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Dec 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Mgmt.Core Azure management core issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

5 participants