Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Changes to SearchClient.search #20524

Closed
Mohit-Chakraborty opened this issue Sep 2, 2021 · 1 comment · Fixed by #20602
Closed

[Search] Changes to SearchClient.search #20524

Mohit-Chakraborty opened this issue Sep 2, 2021 · 1 comment · Fixed by #20602
Assignees
@tjprescott
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2021] October

Comments

@Mohit-Chakraborty
Copy link

image
@Mohit-Chakraborty Mohit-Chakraborty added the Mgmt This issue is related to a management-plane library. label Sep 2, 2021
@tjprescott tjprescott self-assigned this Sep 2, 2021
@tjprescott tjprescott added Client This issue points to a problem in the data-plane of the library. and removed Mgmt This issue is related to a management-plane library. labels Sep 2, 2021
@tjprescott tjprescott added this to the [2021] October milestone Sep 7, 2021
@tjprescott tjprescott changed the title [Search] Define SDK-only properties for 2 SearchOptions parameters [Search] Changes to SearchOptions Sep 7, 2021
@tjprescott
Copy link
Member

tjprescott commented Sep 7, 2021 •
edited
Loading

Summary of changes needed for Python:
Changes to SearchClient.search signature

  • Change speller to query_speller
  • Construct answers property from two custom properties query_answer and query_answer_count
  • Construct captions property from two custom properties query_caption and query_caption_highlight.
  • Add semantic_fields property.

@tjprescott tjprescott changed the title [Search] Changes to SearchOptions [Search] Changes to SearchClient.search Sep 8, 2021
@tjprescott tjprescott mentioned this issue Sep 8, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tjprescott tjprescott

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2021] October
Development

Successfully merging a pull request may close this issue.

[Search] Update SearchClient.search API
2 participants
@tjprescott @Mohit-Chakraborty