Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uamqp] Remove loop as a param #9307

Closed
YijunXieMS opened this issue Jan 3, 2020 · 2 comments · Fixed by #19953
Closed

[uamqp] Remove loop as a param #9307

YijunXieMS opened this issue Jan 3, 2020 · 2 comments · Fixed by #19953
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew uAMQP
Milestone

Comments

@YijunXieMS
Copy link
Contributor

Python 3.10 asyncio will remove loop as a param in some functions. For instance, asyncio.sleep(), shield(), wait_for(), etc. Uamqp should remove them.
Python 3.8 asyncio has deprecated param loop in these functions.

@YijunXieMS YijunXieMS added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jan 3, 2020
@yunhaoling yunhaoling added this to the Backlog milestone Mar 19, 2021
@yunhaoling
Copy link
Contributor

quick notes:

  • if loop is positional, raise TypeError for 3.10
  • we should find all the SB/EH public leaking places
    • positional argument
    • keyword argument
      • we have more flexibility if it's kwargs we could do docstring/logging stuff

@swathipil
Copy link
Member

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew uAMQP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants