Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate tests that still require sleeps #102

Open
jhendrixMSFT opened this issue Nov 19, 2021 · 0 comments
Open

Investigate tests that still require sleeps #102

jhendrixMSFT opened this issue Nov 19, 2021 · 0 comments

Comments

@jhendrixMSFT
Copy link
Member

There are some tests that require a time.Sleep() between actions. Some of these are due to legitimate races, e.g. in conn_test.go TestClose, starting and immediately stopping the connection never gives the connReader, connWriter, and mux goroutines to start. This is a corner-case, but the race is real.

This is further surfaced in NetConn, having to use a buffered channel for the reader (see code comment for full explanation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant