Issue deploying to Azure Gov

[Tukeyz]

I have no idea as i dont know coding, but i am getting this error

"[parameters('hubVirtualNetworkDiagnosticsMetrics')]"
The template has specified this parameter as type 'array', but the default value is specified as type 'string'. This template may not deploy correctly.
Unable to parse value to type 'array'. The value must be a valid JSON array.
how do i resolve this error message

[brooke-hamilton]

@Turkeyz thank you for the feedback! Can you add more detail that will help us reproduce the issue? For example, steps to reproduce and/or a pointer to any instructions you were following, and input data you used.

[techdawg70]

Hi Brooke - this error is seen when a user navigates the github repo to the Command-Line-Deployment section then clicks the "Deploy" link under the "Deploy with Bicep (recommended)" option block. From here the user clicks the button "Deploy to Azure Gov" which redirects the user to their Az Gov tenant -> custom deployment template for MLZ. This error is seen against the following arears -> Identity Virtual Network Diagnostics Logs, Identity Virtual Network Diagnostics Metrics, Identity Network Security Group Rules, Identity Network Security Group Diagnostics Logs, Identity Network Security Group Diagnostics Metrics, Identity Subnet Service Endpoints, Operations Virtual Network Diagnostics Logs, Operations Virtual Network Diagnostics Metrics, Operations Network Security Group Rules, Operations Network Security Group Diagnostics Logs, Operations Network Security Group Diagnostics Metrics, Operations Subnet Service Endpoints, Shared Services Virtual Network Diagnostics Logs, Shared Services Virtual Network Diagnostics Metrics, Shared Services Network Security Group Rules, Shared Services Network Security Group Diagnostics Logs, Shared Services Network Security Group Diagnostics Metrics, Shared Services Subnet Service Endpoints

[brooke-hamilton]

Thanks for the additional info. I will take a look. 💯

[glennmusa]

It appears the custom deployment template doesn't support parsing shared array parameters:

The template has specified this parameter as type 'array', but the default value is specified as type 'string'. This template may not deploy correctly.

Manually modifying the form value to remove the string " characters from the inputs that trigger this validation allows the deployment to begin:

Odd behavior given this value is defaulted as an array type here:

missionlz/src/bicep/mlz.bicep

Line 465 in e042e9d

param operationsSubnetServiceEndpoints array = hubSubnetServiceEndpoints

and read from this value, which is also an array:

missionlz/src/bicep/mlz.bicep

Lines 369 to 373 in e042e9d

	param hubSubnetServiceEndpoints array = [
	{
	service: 'Microsoft.Storage'
	}
	]

but what is generated in the ARM template that the custom deployment uses is a string value:

missionlz/src/bicep/mlz.json

Lines 375 to 378 in 3a7cb05

	"operationsSubnetServiceEndpoints": {
	"type": "array",
	"defaultValue": "[parameters('hubSubnetServiceEndpoints')]"
	},

you can see the value it references is not a string, but starts with [ an array type:

missionlz/src/bicep/mlz.json

Lines 131 to 138 in 3a7cb05

	"hubSubnetServiceEndpoints": {
	"type": "array",
	"defaultValue": [
	{
	"service": "Microsoft.Storage"
	}
	]
	},

will investigate and propose a fix

[brooke-hamilton]

For now we have removed the Azure portal templates from the main branch until we get a fix. The command-line deployments using the AZ CLI are not affected by this issue. See PR #516

[brooke-hamilton]

#482 is a similar issue and is being addressed too.

[brooke-hamilton]

This bug will be resolved with #482, which is currently in progress.