[Feature Request] [L] Support for Windows WinUI 3 desktop apps

[andrewleader]

The Microsoft.Identity.Client library doesn't support Windows WinUI 3 desktop Project Reunion apps today. I think the library is seeing the net5.0-windows TFM and thinking it's a WPF or WinForms app, and therefore doesn't work with a WinUI 3 app (which is neither of those).

Describe the solution you'd like
Microsoft.Identity.Client library works with WinUI 3 desktop apps.

Additional context
To reproduce...

1. First set up dev environment (install Reunion VSIX): https://docs.microsoft.com/en-us/windows/apps/project-reunion/set-up-your-development-environment
2. Then create a WinUI desktop app: https://docs.microsoft.com/en-us/windows/apps/winui/winui3/get-started-winui3-for-desktop
3. Then add the Microsoft.Identity.Client NuGet package to the app and attempt to build and run the app

[igalfsg]

Is this planned for 4.35.0?

[jmprieur]

It's going to be investigated first. We need to understand what needs to be done, @igalfsg
If you know already, don't hesitate to provide hints.

[igalfsg]

@jmprieur I haven't looked into the library's code. However, version 4.27.1 still works with Win UI 3. That was before it was switched from the in app prompt to browser authentication so I would guess it has something to do with how that feature was implemented.

[trwalke]

The same issue seems to be open in the Microsoft.UI.XAML repo
microsoft/microsoft-ui-xaml#5143

I also tried using VS 2022 to build but I run into the same error

[bgavrilMS]

This is most likely due to WinUI. MSAL has a tfm of net5.0-windows10.0.17763.0 and WinUI app has net5.0-windows10.0.19xxx. MSAL calls into WinRT on its own.

[marb2000]

I couldn't repro the bug. I created a Blank C# WinUI 3 app using the Windows App SDK 0.8.1, added the MSAL.NET library, and the project was built. I got an error that does not block the build. WinUI 3 supports arm64 and I guess MASL.NET doesn't:

There was no runtime pack for Microsoft.WindowsDesktop.App.WindowsForms available for the specified RuntimeIdentifier 'win10-arm64'.

[trwalke]

Thanks @marb2000. Ill verify that I installed 0.8.1 and try again.

[jmiddour]

I can confirm that the behavior still remains. I don't know if it's WinUI's issue to fix or the identity client.
I've messed with the tfms and runtime ids a lot, and haven't gotten a working combination with v4.35 yet running vs16.11 preview. Though for me, the missing runtime pack is a build blocker.

[bgavrilMS]

This is unlikely to be a Microsoft.Identity.Client problem. The error comes from a targets file introduced by WinUI

Microsoft.UI.Xaml.Markup.Compiler.interop.targets(465,9): Xaml Internal Error error WMC9999: **Operation is not supported on this platform.

MSAL is a standard .NET library with a target on .net5-windows10.0.17763.0, which calls into WinRT APIs.

[hachadwick]

I am not sure if this has been stated before but, I am able to use Microsoft.Identity.Client version 4.27.1 without issue in my WINUI 3 app. If I use a version later than that, I get an build error. It appears the issue was introduced in version 4.28.0, possibly.

[bgavrilMS]

The issue should have been fixed @hachadwick , we're waiting for an SDK that has the fix to verify this.

[hachadwick]

The issue should have been fixed @hachadwick , we're waiting for an SDK that has the fix to verify this.

I appreciate the reply. I'll be looking for the updated SDK.

[hachadwick]

Will this issue/ticket be closed when the SDK is updated?

[andrewleader]

@bgavrilMS you can use 1.0.0-preview2 of the WinAppSDK, that has the fix and is publicly available now.

[bgavrilMS]

@trwalke was looking into this, he'll can give it a go early next week.

[trwalke]

Need to do basic smoke testing to ensure new preview works

[emorell96]

This has come back now with MAUI in RC1: dotnet/maui#6052
The build fails with two errors when MSAL is added to a MAUI library. Any idea how to avoid building for arm? I have no need to support arm on windows.

2>C:\Program Files\dotnet\sdk\6.0.300-preview.22204.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(427,5): error NETSDK1082: There was no runtime pack for Microsoft.WindowsDesktop.App.WindowsForms available for the specified RuntimeIdentifier 'win10-arm'.
2>C:\Program Files\dotnet\sdk\6.0.300-preview.22204.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(427,5): error NETSDK1082: There was no runtime pack for Microsoft.WindowsDesktop.App.WindowsForms available for the specified RuntimeIdentifier 'win10-arm-aot'.

[bgavrilMS]

This works today, there is nothing to do.

[diemperdiem]

So I'm using WinUI in .NET 6.0-pre (net6.0-windows10.0.19041) as part of the standard project template that shipped with MAUI Preview 7. It's using ProjectReunion 0.8.1.

I get a hard crash in my Startup.ConfigureServices routine when trying to build a IPublicClientApplication using Microsoft.Identity.Client.

Having read through this post I have tried various versions of the Microsoft.Identity.Client library:

• 4.34.1
• 4.27.1
• 4.16.1 (just for luck)
• 4.10.1 (just for luck)

None workaround the issue.

Because it's a hard crash I've been unable to catch the exception using a TRY/CATCH block.

I know most of the conversation here has revolved around compatibility with .NET 5.0 but I'm wondering if anyone has any ideas for a workaround for .NET 6.0 / MAUI Preview 7, please?

Cheers.

@PaulSorauer-IPG Any luck?

[bgavrilMS]

@diemperdiem - we expect this to work. Please open a new bug if it isn't.

[rossirpaulo]

Should not be closed. This does not work if WindowsAppSDKSelfContained is set to true.

[bgavrilMS]

@rossirpaulo - please open a bug for this

[baskren]

Here is the bug : #3941
Why it's closed is a mystery to me.