Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ' in FileDescription #19

Open
UnexomWid opened this issue May 5, 2024 · 0 comments
Open

Support for ' in FileDescription #19

UnexomWid opened this issue May 5, 2024 · 0 comments

Comments

@UnexomWid
Copy link

Hello and thanks for the crate!

If the package description contains the ' character, it will show up as \' in the file properties when compiling with rc.exe.

Example:

[package]
description = "SomeUser's FooBar Project"

This generates the following:

VALUE "FileDescription", "SomeUser\'s FooBar Project"

All good so far. I expected Microsoft's resource compiler to escape it, since it's a valid C escape sequence.

However, it doesn't seem to do so, and it just inserts \' as-is, making the description in the properties:

SomeUser\'s FooBar Project

I also tried running rc.exe manually on the resource file, and it led to the same result. Seems like it's rc.exe's fault.

Removing this line will get rid of the escape, and will generate "SomeUser's FooBar Project". The compiler seems to have no issue with that and works properly.

Not sure if removing the escape sequence for ' will impact something else, but my guess is that it won't.

I can create a PR with this fix if it's all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant