Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update npm package with new d.ts file #284

Closed
bherila opened this issue Apr 25, 2017 · 8 comments
Closed

Please update npm package with new d.ts file #284

bherila opened this issue Apr 25, 2017 · 8 comments

Comments

@bherila
Copy link

bherila commented Apr 25, 2017

Since merging #232 it would be very helpful to be able to install that updated file from npm

When will we be able to see the updated file in the npm package? Doesn't look like it got included in the last release for some reason.

Thanks,
Ben

@BenjaminVanRyseghem
Copy link
Owner

BenjaminVanRyseghem commented Apr 26, 2017

euh ok :/ I will investigate 😄

Not sure to have the time this week, I will try to do it next monday if that's ok. Do not hesitate to ping me if I forget 😄

@bherila
Copy link
Author

bherila commented Apr 26, 2017

Thanks, I have copied the file manually for the time being, but it keeps getting overwritten when the build script reinstalls all the packages.

@sousarka
Copy link
Contributor

sousarka commented May 1, 2017

@BenjaminVanRyseghem Can you please publish?

@BenjaminVanRyseghem
Copy link
Owner

on it 😄

@BenjaminVanRyseghem
Copy link
Owner

This should be in numbro 1.11.0 😄

@BenjaminVanRyseghem
Copy link
Owner

can you confirm?

@sousarka
Copy link
Contributor

sousarka commented May 2, 2017

the new numbro type definition (numbro.d.ts) is perfectly working.. Thank you so much for this awesome library.

@bherila
Copy link
Author

bherila commented May 3, 2017

Awesome, thank you so much!! 👍

@bherila bherila closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants