Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : Filter functionality in our beacons #155

Open
Arjun2905 opened this issue Mar 13, 2022 · 3 comments
Open

Feature Request : Filter functionality in our beacons #155

Arjun2905 opened this issue Mar 13, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Arjun2905
Copy link

Is your feature request related to a problem? Please describe.
Suppose in crew of several members different people are able to create a beacon. It will become a tedious task to look upon every beacon to search a particular beacon.

Describe the solution you'd like
Here the filter functionality can play a vital role to optimize searching based on the person who had created a beacon. Currently in every beacon card has beacon name and who had made it as "Beacon Name by Creator Name" So at the time when we take information from backend about every beacon and display it on cards we will store the owner names in a set and use these names to provide filter functionality.

Describe alternatives you've considered
Alternative to this can be to implement search bar where user can search a particular beacon name. But in this case we need to know perfect name of beacon otherwise we'll end up no result found.

Additional context

  1. Use of Icon Button (with provided button color in theme as yellow).
  2. Use of pop-up menu by onTap on icon button.
  3. Showing the list of all beacon owners of whom we have joined the beacons from earlier(like as if we have registered it).

Are you working on this? (Yes/No)
Yes

@Arjun2905
Copy link
Author

@nb9960 would like to hear some of your suggestion's on it.

@cfsmp3
Copy link
Collaborator

cfsmp3 commented Mar 14, 2022

This is a useful feature for sure; however searching by "name" is going to be incomplete, if name here means the name of the person.

Suppose this very common use case: A hike group that goes out every weekend have several leaders, and one of them takes the group out each day. There's many people that can go on these hikes (as "followers") who may or may not go.

My point here is that we'd need to introduce the concept of "group" (which I believe we still don't have) and followers should be able to follow groups or search for group; you don't really care who created the beacon but rather who has the beacon for a group.

It's definitely a good idea; just need some refining so it can adjust to the actual use cases.

@Arjun2905
Copy link
Author

Arjun2905 commented Mar 18, 2022

@cfsmp3 yeah according to the existing codebase your point seems to be completely valid over here, Earlier I was thinking of displaying names of those people only who have created a beacon but thinking on your advice I guess it will just clatter the names of all people who have created any beacon and for that we need groups functionality for that. I'll definitely try to put your advice in well planned manner in my proposal.

@nb9960 nb9960 added the enhancement New feature or request label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants