Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google & Facebook oauth sign up and sign in #160

Open
jaiakash opened this issue Apr 15, 2022 · 11 comments
Open

Google & Facebook oauth sign up and sign in #160

jaiakash opened this issue Apr 15, 2022 · 11 comments
Labels
backend Change required in the backend enhancement New feature or request

Comments

@jaiakash
Copy link

jaiakash commented Apr 15, 2022

Is your feature request related to a problem? Please describe.
Currently, the app only accepts email sign in/signup. Having oauth would be better for the user, then user can sign in with ease.
Also there is PR for email verification, having oauth wont even need email verification. (Although that feature would be required for user sign in with their email).

Describe the solution you'd like
Having a google and/or Facebook oauth at sign-in page of app.

Are you working on this? (Yes/No)
Not right now, but if I get confirmation from maintainer, I would start working on it.

@codewithkushagra
Copy link
Contributor

I would like to work on this, I have implemented oauth in flutter previously, I can do it
Can you assign it to me

@nb9960
Copy link
Collaborator

nb9960 commented Apr 18, 2022

@jaiakash @codewithkushagra Yes, this was planned but how will you guys implement it without updating the backend?

@nb9960 nb9960 added enhancement New feature or request backend Change required in the backend labels Apr 18, 2022
@codewithkushagra
Copy link
Contributor

Actually, we don't have to make too many changes to backend, as by using google_sigin package we can maintain the login states, access tokens and refresh token in frontend itself and I will try to make the required changes in backend.

@jaiakash
Copy link
Author

Yeah i agree, there are packages for facebook and google oauth which we can use without much changes in backend.
Blog link - link
Facebook package
Google package

@ItsAdityaKSingh
Copy link
Collaborator

Are you working on proposing changes for this issue @jaiakash?

@codewithkushagra
Copy link
Contributor

Hey, @ItsAdityaKSingh if @jaiakash is not working on this can I work on it?
I have previously implemented such features so I can implement it easily, let me know if issue open to work on

@jaiakash
Copy link
Author

Are you working on proposing changes for this issue @jaiakash?

No, I am not actively working on it. I guess @codewithkushagra can it if he has worked on a similar issue previously.

@ItsAdityaKSingh
Copy link
Collaborator

Ok! If @codewithkushagra you are willing to resolve this issue, I would like to discuss it first. Like how are you planning to change the backend to implement this feature? Currently, whoever registers, the information regarding the users, list of beacons, and everything is saved in our customized backend, where we easily retrieve the information about them. Using Google or Facebook would need to change how we currently keep records. What do you suggest?

@asmitranjansinha
Copy link

we can use firebase and google/facebook auth packages

@asmitranjansinha
Copy link

if anyone is not working on this issue, I can work on it @ItsAdityaKSingh

@lalitkumawat1m
Copy link

Hi, could you please assign this issue to me?
I would love to work on it and contribute to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change required in the backend enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants