Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hike Screen] Unexpected behaviour when leader tries to change duration. #17

Open
Aadeesh11 opened this issue Dec 26, 2021 · 6 comments · May be fixed by #97
Open

[Hike Screen] Unexpected behaviour when leader tries to change duration. #17

Aadeesh11 opened this issue Dec 26, 2021 · 6 comments · May be fixed by #97
Assignees
Labels
backend Change required in the backend desired feature enhancement New feature or request

Comments

@Aadeesh11
Copy link
Contributor

When the leader tries to change the duration, the dialogue that pops up does not provide an option to change duration.

DurationChangeError

I would like to work on this, please assign this to me.

@nb9960
Copy link
Collaborator

nb9960 commented Dec 26, 2021

Changing duration feature was planned to be implemented but wasn't implemented. I don't remember exactly if this was implemented on the backend or not. Check the backend schema here before working on this.

@Aadeesh11
Copy link
Contributor Author

Thanks, will have a look.

@Aadeesh11
Copy link
Contributor Author

Changing duration feature was planned to be implemented but wasn't implemented. I don't remember exactly if this was implemented on the backend or not. Check the backend schema here before working on this.

I had a look at the schema, as much as i understood, there was no mutation available to change the duration/time of the beacon.
So should we remove the text that says "double tap to change duration" as it leads to unexpected UX and also the button that opens the dialogue maybe?

@nb9960
Copy link
Collaborator

nb9960 commented Dec 27, 2021

Instead of removing that part, comment it out (adding Todo: and the reason why it's not being implemented) as this feature is necessary and needs to be implemented later.
And let's wait for this to get implemented on the backend first.

@nb9960 nb9960 added desired feature backend Change required in the backend enhancement New feature or request labels Dec 27, 2021
@Aadeesh11
Copy link
Contributor Author

Thanks, will comment it out. 👍

@Rushour0
Copy link

Hey is this issue resolved? @nb9960 Would like to work on it if it hasn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change required in the backend desired feature enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants